[GitHub] spark pull request: Delete unnecessary function

2014-11-28 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/3224#issuecomment-64907431 Jenkins, test this please. LGTM pending tests - this just pulls in clean-up from upstream. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: Delete unnecessary function

2014-11-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3224#issuecomment-64907914 [Test build #23939 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23939/consoleFull) for PR 3224 at commit

[GitHub] spark pull request: Delete unnecessary function

2014-11-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3224#issuecomment-64914989 [Test build #23939 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23939/consoleFull) for PR 3224 at commit

[GitHub] spark pull request: Delete unnecessary function

2014-11-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3224 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: Delete unnecessary function

2014-11-27 Thread KaiXinXiaoLei
Github user KaiXinXiaoLei commented on the pull request: https://github.com/apache/spark/pull/3224#issuecomment-64788339 @JoshRosen ping. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Delete unnecessary function

2014-11-25 Thread KaiXinXiaoLei
GitHub user KaiXinXiaoLei reopened a pull request: https://github.com/apache/spark/pull/3224 Delete unnecessary function when building spark by sbt, the function “runAlternateBoot in sbt/sbt-launch-lib.bash is not used. And this function is not used by spark code. So I think

[GitHub] spark pull request: Delete unnecessary function

2014-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3224#issuecomment-64384870 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: Delete unnecessary function

2014-11-25 Thread KaiXinXiaoLei
Github user KaiXinXiaoLei commented on the pull request: https://github.com/apache/spark/pull/3224#issuecomment-64385026 The file from https://github.com/sbt/sbt-launcher-package is changed. And the function “runAlternateBoot is deleted in upstream project. I think spark project

[GitHub] spark pull request: Delete unnecessary function

2014-11-25 Thread KaiXinXiaoLei
Github user KaiXinXiaoLei commented on the pull request: https://github.com/apache/spark/pull/3224#issuecomment-64385336 The file from https://github.com/sbt/sbt-launcher-package is changed. And the function “runAlternateBoot is deleted in upstream project. I think spark project

[GitHub] spark pull request: Delete unnecessary function

2014-11-13 Thread KaiXinXiaoLei
Github user KaiXinXiaoLei commented on the pull request: https://github.com/apache/spark/pull/3224#issuecomment-62883101 OK. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: Delete unnecessary function

2014-11-13 Thread KaiXinXiaoLei
Github user KaiXinXiaoLei closed the pull request at: https://github.com/apache/spark/pull/3224 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: Delete unnecessary function.

2014-11-12 Thread KaiXinXiaoLei
GitHub user KaiXinXiaoLei opened a pull request: https://github.com/apache/spark/pull/3223 Delete unnecessary function. when building spark by sbt, the function “runAlternateBoot in sbt/sbt-launch-lib.bash is not used. And this function is not used by spark code. So I think

[GitHub] spark pull request: Delete unnecessary function.

2014-11-12 Thread KaiXinXiaoLei
Github user KaiXinXiaoLei closed the pull request at: https://github.com/apache/spark/pull/3223 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: Delete unnecessary function

2014-11-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3224#issuecomment-62693270 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: Delete unnecessary function

2014-11-12 Thread KaiXinXiaoLei
GitHub user KaiXinXiaoLei opened a pull request: https://github.com/apache/spark/pull/3224 Delete unnecessary function when building spark by sbt, the function “runAlternateBoot in sbt/sbt-launch-lib.bash is not used. And this function is not used by spark code. So I think this

[GitHub] spark pull request: Delete unnecessary function

2014-11-12 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/3224#issuecomment-62694334 I believe this file is cloned from the SBT project. While this might or might not be used by Spark, it's probably easiest to not delete it, so as to make updating the

[GitHub] spark pull request: Delete unnecessary function

2014-11-12 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3224#issuecomment-62777549 Yeah, this file is from https://github.com/sbt/sbt-launcher-package. Maybe it's not necessary, but I'd rather not think about / review changes to this third-party