[GitHub] spark pull request: Fix postfixOps warnings in the test suite

Github user willb commented on the pull request: https://github.com/apache/spark/pull/1323#issuecomment-55345856 Hi @jkbradley; thanks for taking a look. Here are the warnings as I see them when compiling tests on the immediate ancestor of my branch, which is 56e009d (I'm running on

[GitHub] spark pull request: Fix postfixOps warnings in the test suite

Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/1323#issuecomment-55347991 Hi @wllib can you comment on #1330? What is the difference between that patch and this, and which is the better approach? --- If your project is set up for it, you

[GitHub] spark pull request: Fix postfixOps warnings in the test suite

Github user willb commented on the pull request: https://github.com/apache/spark/pull/1323#issuecomment-55351655 Hey @andrewor14, thanks for the reply. First off, I absolutely agree with @srowen's comment on #1330 that `import`s (not compiler flags) are the right way to handle

[GitHub] spark pull request: Fix postfixOps warnings in the test suite

Github user willb closed the pull request at: https://github.com/apache/spark/pull/1323 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: Fix postfixOps warnings in the test suite

Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/1323#issuecomment-55352231 I see, thanks for your patch anyway! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: Fix postfixOps warnings in the test suite

Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/1323#issuecomment-55194405 @willb Hi, I was asked to take a look at this. I tried the current master + this PR merged with master, and I did not see much difference in warnings (or any

[GitHub] spark pull request: Fix postfixOps warnings in the test suite

Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/1323#issuecomment-53340472 @willb @witgo What is the difference between your patches? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: Fix postfixOps warnings in the test suite

Github user willb commented on the pull request: https://github.com/apache/spark/pull/1323#issuecomment-51378794 Can someone take a look at this again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: Fix postfixOps warnings in the test suite

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1323#issuecomment-51068459 QA tests have started for PR 1323. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17854/consoleFull ---

[GitHub] spark pull request: Fix postfixOps warnings in the test suite

Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1323#issuecomment-51069490 Related work #1330 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: Fix postfixOps warnings in the test suite

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1323#issuecomment-51076281 QA results for PR 1323:br- This patch PASSES unit tests.br- This patch merges cleanlybr- This patch adds no public classesbrbrFor more information see test

[GitHub] spark pull request: Fix postfixOps warnings in the test suite

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1323#issuecomment-48329998 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16407/ --- If your

[GitHub] spark pull request: Fix postfixOps warnings in the test suite

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1323#issuecomment-48329997 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.