[GitHub] spark pull request: Fix scheduler to account for tasks using 1 C...

2014-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/219#issuecomment-38534171 One or more automated tests failed Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13423/ --- If your

[GitHub] spark pull request: Fix scheduler to account for tasks using 1 C...

2014-03-25 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/219#issuecomment-38592694 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: Fix scheduler to account for tasks using 1 C...

2014-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/219#issuecomment-38600307 One or more automated tests failed Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13437/ --- If your

[GitHub] spark pull request: Fix scheduler to account for tasks using 1 C...

2014-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/219#issuecomment-38600305 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Fix scheduler to account for tasks using 1 C...

2014-03-25 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/219#issuecomment-38601404 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Fix scheduler to account for tasks using 1 C...

2014-03-25 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/219#issuecomment-38601384 Failure was in recovery with file input stream.recovery with file input stream -- Something that I think is completely unrelated to this change. So lets try again ...

[GitHub] spark pull request: Fix scheduler to account for tasks using 1 C...

2014-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/219#issuecomment-38601510 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: Fix scheduler to account for tasks using 1 C...

2014-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/219#issuecomment-38608422 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13440/ --- If your project

[GitHub] spark pull request: Fix scheduler to account for tasks using 1 C...

2014-03-25 Thread mridulm
Github user mridulm commented on the pull request: https://github.com/apache/spark/pull/219#issuecomment-38608715 Looks good, thanks for the change - makes things cleaner. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: Fix scheduler to account for tasks using 1 C...

2014-03-24 Thread shivaram
GitHub user shivaram opened a pull request: https://github.com/apache/spark/pull/219 Fix scheduler to account for tasks using 1 CPUs. Move CPUS_PER_TASK to TaskSchedulerImpl as the value is a constant and use it in both Mesos and CoarseGrained scheduler backends. Thanks

[GitHub] spark pull request: Fix scheduler to account for tasks using 1 C...

2014-03-24 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/219#discussion_r10915292 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala --- @@ -62,6 +62,9 @@ private[spark] class TaskSchedulerImpl( //

[GitHub] spark pull request: Fix scheduler to account for tasks using 1 C...

2014-03-24 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/219#discussion_r10915339 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala --- @@ -62,6 +62,9 @@ private[spark] class TaskSchedulerImpl( //

[GitHub] spark pull request: Fix scheduler to account for tasks using 1 C...

2014-03-24 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/219#discussion_r10915407 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala --- @@ -62,6 +62,9 @@ private[spark] class TaskSchedulerImpl( //

[GitHub] spark pull request: Fix scheduler to account for tasks using 1 C...

2014-03-24 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/219#issuecomment-38524982 FYI - there was a test failure in TaskSetManagerSuite as a unit test was checking for availableCpus being zero. So I added back a non-zero check in TaskSetManager. ---

[GitHub] spark pull request: Fix scheduler to account for tasks using 1 C...

2014-03-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/219#issuecomment-38526638 One or more automated tests failed Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13414/ --- If your

[GitHub] spark pull request: Fix scheduler to account for tasks using 1 C...

2014-03-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/219#issuecomment-38526636 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Fix scheduler to account for tasks using 1 C...

2014-03-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/219#issuecomment-38526736 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: Fix scheduler to account for tasks using 1 C...

2014-03-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/219#issuecomment-38527171 One or more automated tests failed Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13417/ --- If your

[GitHub] spark pull request: Fix scheduler to account for tasks using 1 C...

2014-03-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/219#issuecomment-38527170 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Fix scheduler to account for tasks using 1 C...

2014-03-24 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/219#issuecomment-38529622 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Fix scheduler to account for tasks using 1 C...

2014-03-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/219#issuecomment-38529627 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Fix scheduler to account for tasks using 1 C...

2014-03-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/219#issuecomment-38529626 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: Fix scheduler to account for tasks using 1 C...

2014-03-24 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/219#discussion_r10917822 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -388,7 +385,7 @@ private[spark] class TaskSetManager(

[GitHub] spark pull request: Fix scheduler to account for tasks using 1 C...

2014-03-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/219#issuecomment-38531549 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13421/ --- If your project

[GitHub] spark pull request: Fix scheduler to account for tasks using 1 C...

2014-03-24 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/219#discussion_r10918164 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -388,7 +385,7 @@ private[spark] class TaskSetManager(

[GitHub] spark pull request: Fix scheduler to account for tasks using 1 C...

2014-03-24 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/219#discussion_r10918370 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala --- @@ -62,6 +62,9 @@ private[spark] class TaskSchedulerImpl( //