[GitHub] spark pull request: Make SQL keywords case-insensitive

2014-03-21 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/193#issuecomment-38337945 Alright, I'll push a commit to update the doc. I agree this is not good for performance -- just make sure you don't add much longer SQL keywords, because the cost i

[GitHub] spark pull request: Make SQL keywords case-insensitive

2014-03-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/193 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] spark pull request: Make SQL keywords case-insensitive

2014-03-21 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/193#issuecomment-38337553 Good catch @pwendell. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: Make SQL keywords case-insensitive

2014-03-21 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/193#issuecomment-38337493 @mateiz @marmbrus does this need to update the programming guide (which currently says they are case sensitive in bold)? --- If your project is set up for it, you can re

[GitHub] spark pull request: Make SQL keywords case-insensitive

2014-03-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/193#issuecomment-38336273 Thanks. I've merged this., --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: Make SQL keywords case-insensitive

2014-03-21 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/193#issuecomment-38336249 This is obviously not a permanent solution as I imagine this makes our parser combinators even slower than they were before... but this is definitely better than it was b

[GitHub] spark pull request: Make SQL keywords case-insensitive

2014-03-21 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/193#issuecomment-38336193 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[GitHub] spark pull request: Make SQL keywords case-insensitive

2014-03-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/193#issuecomment-38258458 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Make SQL keywords case-insensitive

2014-03-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/193#issuecomment-38258462 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13317/ --- If your project

[GitHub] spark pull request: Make SQL keywords case-insensitive

2014-03-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/193#issuecomment-38255593 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request: Make SQL keywords case-insensitive

2014-03-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/193#issuecomment-38255594 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark pull request: Make SQL keywords case-insensitive

2014-03-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/193#issuecomment-38255468 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13315/ --- If your project

[GitHub] spark pull request: Make SQL keywords case-insensitive

2014-03-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/193#issuecomment-38255467 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Make SQL keywords case-insensitive

2014-03-21 Thread mateiz
GitHub user mateiz opened a pull request: https://github.com/apache/spark/pull/193 Make SQL keywords case-insensitive This is a bit of a hack that allows all variations of a keyword, but it still seems to produce valid error messages and such. You can merge this pull request into a

[GitHub] spark pull request: Make SQL keywords case-insensitive

2014-03-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/193#issuecomment-3825 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request: Make SQL keywords case-insensitive

2014-03-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/193#issuecomment-38253334 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t