[GitHub] spark pull request: SPARK-11402: Use ChildRunnerProvider to create...

2016-05-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9354 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: SPARK-11402: Use ChildRunnerProvider to create...

2016-04-28 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9354#issuecomment-215353152 Yes, this PR should be closed. Per discussion in the JIRA, this just is too much SPI to open up for not obvious gain. There may be much more modest refactorings that

[GitHub] spark pull request: SPARK-11402: Use ChildRunnerProvider to create...

2016-04-27 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/9354#issuecomment-215233423 So I feel like I'm missing the motivation for this change, it seems like @srowen also had some concerns with what the goals were for this in the JIRA. --- If your

[GitHub] spark pull request: SPARK-11402: Use ChildRunnerProvider to create...

2016-04-19 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/9354#issuecomment-212184780 Maybe we might have to correct the title just like the others, `[SPARK-][SQL]` (this is described in

[GitHub] spark pull request: SPARK-11402: Use ChildRunnerProvider to create...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9354#issuecomment-152182642 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: SPARK-11402: Use ChildRunnerProvider to create...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9354#issuecomment-152182613 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: SPARK-11402: Use ChildRunnerProvider to create...

2015-10-29 Thread jacek-lewandowski
GitHub user jacek-lewandowski opened a pull request: https://github.com/apache/spark/pull/9354 SPARK-11402: Use ChildRunnerProvider to create ExecutorRunner and DriverRunner Abstracted ExecutorRunner and DriverRunner. The current implementations were renamed to ExecutorRunnerImpl

[GitHub] spark pull request: SPARK-11402: Use ChildRunnerProvider to create...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9354#issuecomment-152211020 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-11402: Use ChildRunnerProvider to create...

2015-10-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9354#issuecomment-152210892 **[Test build #44599 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44599/consoleFull)** for PR 9354 at commit

[GitHub] spark pull request: SPARK-11402: Use ChildRunnerProvider to create...

2015-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9354#issuecomment-152211022 Test FAILed. Refer to this link for build results (access rights to CI server needed):