Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10585
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10585#issuecomment-178328745
@navis you can close this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10585#issuecomment-174177590
I'll take this over if there's no progress on this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10585#issuecomment-173171129
@navis what do you think about following up on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10585#issuecomment-171944298
I don't feel that strongly but if we're changing this, might as well do it
right with interpolation and making the method `private` @navis
---
If your project is set
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/10585#issuecomment-171443062
Meh, this isn't _that_ hard to read without interpolation, so I'd be okay
with merging this if it's fine with @srowen.
---
If your project is set up for it, you can
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10585#discussion_r49654742
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala ---
@@ -293,6 +293,15 @@ class StatsReportListener extends SparkListener with
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10585#issuecomment-170486935
It's looking good though I still sort of think string interpolation would
make this clearer. I'll leave open for a bit to see if anyone cares either way
on that one
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10585#issuecomment-170421549
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10585#issuecomment-170421478
**[Test build #49078 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49078/consoleFull)**
for PR 10585 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10585#issuecomment-170421550
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10585#issuecomment-170333516
I think this still needs the changes I've mentioned above, or at least,
that's what I'd prefer to see before merging
---
If your project is set up for it, you can
Github user navis commented on the pull request:
https://github.com/apache/spark/pull/10585#issuecomment-170411652
@srowen moved it to `StatsReportListener`. sorry for delay.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10585#issuecomment-170412311
**[Test build #49078 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49078/consoleFull)**
for PR 10585 at commit
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10585#discussion_r48936240
--- Diff: core/src/main/scala/org/apache/spark/scheduler/StageInfo.scala ---
@@ -61,6 +61,21 @@ class StageInfo(
"running"
}
}
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10585#discussion_r48828840
--- Diff: core/src/main/scala/org/apache/spark/scheduler/StageInfo.scala ---
@@ -61,6 +61,21 @@ class StageInfo(
"running"
}
}
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10585#issuecomment-169206444
**[Test build #48803 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48803/consoleFull)**
for PR 10585 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10585#issuecomment-169206545
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10585#issuecomment-169206547
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10585#issuecomment-169181495
**[Test build #48803 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48803/consoleFull)**
for PR 10585 at commit
Github user navis commented on a diff in the pull request:
https://github.com/apache/spark/pull/10585#discussion_r48915612
--- Diff: core/src/main/scala/org/apache/spark/scheduler/StageInfo.scala ---
@@ -61,6 +61,21 @@ class StageInfo(
"running"
}
}
+
Github user navis commented on a diff in the pull request:
https://github.com/apache/spark/pull/10585#discussion_r48916174
--- Diff: core/src/main/scala/org/apache/spark/scheduler/StageInfo.scala ---
@@ -61,6 +61,21 @@ class StageInfo(
"running"
}
}
+
GitHub user navis opened a pull request:
https://github.com/apache/spark/pull/10585
SPARK-12637 Print stage info of finished stages properly
Currently it prints hashcode of stage info, which seemed not that useful.
```
INFO scheduler.StatsReportListener: Finished stage:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10585#issuecomment-168874823
**[Test build #48718 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48718/consoleFull)**
for PR 10585 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10585#issuecomment-168896886
**[Test build #48718 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48718/consoleFull)**
for PR 10585 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10585#issuecomment-168896989
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10585#issuecomment-168896986
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10585#issuecomment-168868540
**[Test build #48714 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48714/consoleFull)**
for PR 10585 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10585#issuecomment-168870006
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10585#issuecomment-168870008
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10585#issuecomment-168870004
**[Test build #48714 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48714/consoleFull)**
for PR 10585 at commit
31 matches
Mail list logo
