[GitHub] spark pull request: SPARK-1428: MLlib should convert non-float64 N...

2014-04-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/356 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] spark pull request: SPARK-1428: MLlib should convert non-float64 N...

2014-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/356#issuecomment-40122134 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] spark pull request: SPARK-1428: MLlib should convert non-float64 N...

2014-04-10 Thread techaddict
GitHub user techaddict reopened a pull request: https://github.com/apache/spark/pull/356 SPARK-1428: MLlib should convert non-float64 NumPy arrays to float64 instead of complaining You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] spark pull request: SPARK-1428: MLlib should convert non-float64 N...

2014-04-10 Thread techaddict
Github user techaddict commented on the pull request: https://github.com/apache/spark/pull/356#issuecomment-40120674 :smile: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] spark pull request: SPARK-1428: MLlib should convert non-float64 N...

2014-04-10 Thread techaddict
Github user techaddict closed the pull request at: https://github.com/apache/spark/pull/356 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] spark pull request: SPARK-1428: MLlib should convert non-float64 N...

2014-04-10 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/356#issuecomment-40119758 Thanks Sandeep. Merged into master and 1.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: SPARK-1428: MLlib should convert non-float64 N...

2014-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/356#issuecomment-40116579 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: SPARK-1428: MLlib should convert non-float64 N...

2014-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/356#issuecomment-40116580 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14002/ --- If your project

[GitHub] spark pull request: SPARK-1428: MLlib should convert non-float64 N...

2014-04-10 Thread techaddict
Github user techaddict commented on the pull request: https://github.com/apache/spark/pull/356#issuecomment-40112564 @mateiz done working now :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: SPARK-1428: MLlib should convert non-float64 N...

2014-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/356#issuecomment-40111911 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1428: MLlib should convert non-float64 N...

2014-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/356#issuecomment-40111891 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: SPARK-1428: MLlib should convert non-float64 N...

2014-04-10 Thread techaddict
Github user techaddict commented on the pull request: https://github.com/apache/spark/pull/356#issuecomment-40110285 New to spark don't know what's the standard way of adding tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] spark pull request: SPARK-1428: MLlib should convert non-float64 N...

2014-04-10 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/356#issuecomment-40107316 This is why it would be good to add a test actually. For instance you can add a test with `_deserialize_double_vector(_serialize_double_vector(array([1,2,3]))` and check t

[GitHub] spark pull request: SPARK-1428: MLlib should convert non-float64 N...

2014-04-10 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/356#issuecomment-40107176 This seems to be failing tests unfortunately -- click through to the Jenkins log. This is what it says: ```

[GitHub] spark pull request: SPARK-1428: MLlib should convert non-float64 N...

2014-04-09 Thread techaddict
Github user techaddict commented on the pull request: https://github.com/apache/spark/pull/356#issuecomment-40046556 @mateiz is there any other problem ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] spark pull request: SPARK-1428: MLlib should convert non-float64 N...

2014-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/356#issuecomment-39933138 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13932/ --- If your project is set up for it, you can r

[GitHub] spark pull request: SPARK-1428: MLlib should convert non-float64 N...

2014-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/356#issuecomment-39933137 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1428: MLlib should convert non-float64 N...

2014-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/356#issuecomment-39931229 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1428: MLlib should convert non-float64 N...

2014-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/356#issuecomment-39931222 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: SPARK-1428: MLlib should convert non-float64 N...

2014-04-08 Thread techaddict
Github user techaddict commented on the pull request: https://github.com/apache/spark/pull/356#issuecomment-39930653 You mean `v = v.astype(float64, copy=True)` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-1428: MLlib should convert non-float64 N...

2014-04-08 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/356#issuecomment-39930461 Sorry meant true, not false. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark pull request: SPARK-1428: MLlib should convert non-float64 N...

2014-04-08 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/356#issuecomment-39930441 Actually one more thing, can you set copy=false in astype? I'm not sure that it preserves the right byte order and such and I know that this works with copy=false. Also we

[GitHub] spark pull request: SPARK-1428: MLlib should convert non-float64 N...

2014-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/356#issuecomment-39929014 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13927/ --- If your project is set up for it, you can r

[GitHub] spark pull request: SPARK-1428: MLlib should convert non-float64 N...

2014-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/356#issuecomment-39929012 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1428: MLlib should convert non-float64 N...

2014-04-08 Thread techaddict
Github user techaddict commented on the pull request: https://github.com/apache/spark/pull/356#issuecomment-39927556 @mateiz updated, should i add tests too (IMHO i don't think there is need, because its a trivial patch :smile: ) ? --- If your project is set up for it, you can reply

[GitHub] spark pull request: SPARK-1428: MLlib should convert non-float64 N...

2014-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/356#issuecomment-39927502 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1428: MLlib should convert non-float64 N...

2014-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/356#issuecomment-39927496 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: SPARK-1428: MLlib should convert non-float64 N...

2014-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/356#issuecomment-39888436 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: SPARK-1428: MLlib should convert non-float64 N...

2014-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/356#issuecomment-39888438 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13897/ --- If your project

[GitHub] spark pull request: SPARK-1428: MLlib should convert non-float64 N...

2014-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/356#issuecomment-39882833 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1428: MLlib should convert non-float64 N...

2014-04-08 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/356#issuecomment-39882724 You should also check that the vector does not contain complex numbers, since that is the one NumPy data type we can't convert to floats. You can do ``` if numpy.iss

[GitHub] spark pull request: SPARK-1428: MLlib should convert non-float64 N...

2014-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/356#issuecomment-39882816 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: SPARK-1428: MLlib should convert non-float64 N...

2014-04-08 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/356#issuecomment-39882618 Jenkins, this is ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark pull request: SPARK-1428: MLlib should convert non-float64 N...

2014-04-08 Thread techaddict
Github user techaddict commented on the pull request: https://github.com/apache/spark/pull/356#issuecomment-39857157 @mengxr ok i'll try adding some test's --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: SPARK-1428: MLlib should convert non-float64 N...

2014-04-08 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/356#issuecomment-39821991 @techaddict Is it easy to add a test to verify that it works? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: SPARK-1428: MLlib should convert non-float64 N...

2014-04-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/356#issuecomment-39816913 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] spark pull request: SPARK-1428: MLlib should convert non-float64 N...

2014-04-07 Thread techaddict
GitHub user techaddict opened a pull request: https://github.com/apache/spark/pull/356 SPARK-1428: MLlib should convert non-float64 NumPy arrays to float64 instead of complaining You can merge this pull request into a Git repository by running: $ git pull https://github.com/t