Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/867
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/867#issuecomment-54694696
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/867#issuecomment-54252552
I think this has been subsumed by #1822, so we should close this issue for
now. If there is anything missing from the implementation there please let us
know!
---
If
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/867#issuecomment-47871283
This is very helpful when the partition can not fit in memory. However, I
think we'd better keep previous implementation; Aggregator in spark is for very
typical
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/867#issuecomment-46646347
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user lamuguo commented on a diff in the pull request:
https://github.com/apache/spark/pull/867#discussion_r13477507
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Aggregate.scala ---
@@ -155,48 +155,60 @@ case class Aggregate(
}
} else
Github user lamuguo commented on a diff in the pull request:
https://github.com/apache/spark/pull/867#discussion_r13217796
--- Diff: core/src/main/scala/org/apache/spark/Aggregator.scala ---
@@ -32,7 +33,8 @@ import org.apache.spark.util.collection.{AppendOnlyMap,
Github user lamuguo commented on a diff in the pull request:
https://github.com/apache/spark/pull/867#discussion_r13217800
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Aggregate.scala ---
@@ -155,48 +155,60 @@ case class Aggregate(
}
} else
Github user lamuguo commented on a diff in the pull request:
https://github.com/apache/spark/pull/867#discussion_r13217803
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Aggregate.scala ---
@@ -155,48 +155,60 @@ case class Aggregate(
}
} else
