GitHub user sryza opened a pull request:
https://github.com/apache/spark/pull/1435
SPARK-2519. Eliminate pattern-matching on Tuple2 in performance-critical...
... aggregation code
You can merge this pull request into a Git repository by running:
$ git pull
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1435#issuecomment-49133777
QA tests have started for PR 1435. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16719/consoleFull
---
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/1435#issuecomment-49133829
Nice. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1435#issuecomment-49141155
QA results for PR 1435:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user markhamstra commented on the pull request:
https://github.com/apache/spark/pull/1435#issuecomment-49174657
Hmmm... not sure that I would go so far as to call it nice. This does
make the code slightly more difficult to read and understand, so can we hope
that you've got
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/1435#issuecomment-49194701
I'm going off of @mateiz 's report on SPARK-2048 that we found [this] to
be much slower than accessing fields directly.
---
If your project is set up for it, you can
Github user markhamstra commented on the pull request:
https://github.com/apache/spark/pull/1435#issuecomment-49195389
Got it. Thanks. That also helps to put some bound (for now) on where we
will make such performance optimizations.
---
If your project is set up for it, you can
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/1435#issuecomment-49203999
Merging in master. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/1435
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
