[GitHub] spark pull request: SPARK-2895: Add mapPartitionsWithContext relat...

2014-09-26 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/2194#issuecomment-57042319 I pushed a commit to close this one in favor of https://github.com/apache/spark/pull/2425 --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: SPARK-2895: Add mapPartitionsWithContext relat...

2014-09-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2194 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: SPARK-2895: Add mapPartitionsWithContext relat...

2014-09-15 Thread ChengXiangLi
Github user ChengXiangLi commented on the pull request: https://github.com/apache/spark/pull/2194#issuecomment-55686321 We still hit API incompatibilities error as https://github.com/apache/spark/pull/2285 is not finished yet. --- If your project is set up for it, you can reply to

[GitHub] spark pull request: SPARK-2895: Add mapPartitionsWithContext relat...

2014-09-15 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/2194#issuecomment-55692911 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-2895: Add mapPartitionsWithContext relat...

2014-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2194#issuecomment-55693096 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20367/consoleFull) for PR 2194 at commit

[GitHub] spark pull request: SPARK-2895: Add mapPartitionsWithContext relat...

2014-09-15 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2194#issuecomment-55695570 I proposed a slightly different approach to this here: https://issues.apache.org/jira/browse/SPARK-3543 This would remove the need for special methods

[GitHub] spark pull request: SPARK-2895: Add mapPartitionsWithContext relat...

2014-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2194#issuecomment-55696453 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20367/consoleFull) for PR 2194 at commit

[GitHub] spark pull request: SPARK-2895: Add mapPartitionsWithContext relat...

2014-09-10 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/2194#issuecomment-55179429 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-2895: Add mapPartitionsWithContext relat...

2014-09-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2194#issuecomment-55206641 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/41/consoleFull) for PR 2194 at commit

[GitHub] spark pull request: SPARK-2895: Add mapPartitionsWithContext relat...

2014-09-10 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/2194#discussion_r17399411 --- Diff: core/src/main/scala/org/apache/spark/api/java/JavaRDDLike.scala --- @@ -186,6 +186,39 @@ trait JavaRDDLike[T, This : JavaRDDLike[T, This]] extends

[GitHub] spark pull request: SPARK-2895: Add mapPartitionsWithContext relat...

2014-09-05 Thread ScrapCodes
Github user ScrapCodes commented on the pull request: https://github.com/apache/spark/pull/2194#issuecomment-54598665 @rxin There is a reason and (workaround type of)fix for this on #2285. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: SPARK-2895: Add mapPartitionsWithContext relat...

2014-09-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2194#issuecomment-54694378 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: SPARK-2895: Add mapPartitionsWithContext relat...

2014-09-04 Thread ChengXiangLi
Github user ChengXiangLi commented on the pull request: https://github.com/apache/spark/pull/2194#issuecomment-54425347 we hit the binary incompatibilities error here, i already annotated new added methods as DeveloperApi, do i miss something here? --- If your project is set up for

[GitHub] spark pull request: SPARK-2895: Add mapPartitionsWithContext relat...

2014-09-04 Thread ScrapCodes
Github user ScrapCodes commented on the pull request: https://github.com/apache/spark/pull/2194#issuecomment-54465038 I am looking at this. Mima check should have excluded those methods. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: SPARK-2895: Add mapPartitionsWithContext relat...

2014-09-03 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/2194#issuecomment-54405450 Jenkins, ok to test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: SPARK-2895: Add mapPartitionsWithContext relat...

2014-09-03 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/2194#issuecomment-54405548 This looks fine to me, especially since it adds Java tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: SPARK-2895: Add mapPartitionsWithContext relat...

2014-09-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2194#issuecomment-54406091 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19738/consoleFull) for PR 2194 at commit

[GitHub] spark pull request: SPARK-2895: Add mapPartitionsWithContext relat...

2014-09-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2194#issuecomment-54409536 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19738/consoleFull) for PR 2194 at commit

[GitHub] spark pull request: SPARK-2895: Add mapPartitionsWithContext relat...

2014-09-02 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/2194#discussion_r17016500 --- Diff: core/src/main/scala/org/apache/spark/api/java/JavaRDDLike.scala --- @@ -186,6 +186,62 @@ trait JavaRDDLike[T, This : JavaRDDLike[T, This]] extends

[GitHub] spark pull request: SPARK-2895: Add mapPartitionsWithContext relat...

2014-09-02 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/2194#discussion_r17016536 --- Diff: core/src/test/java/org/apache/spark/JavaAPISuite.java --- @@ -708,6 +708,104 @@ public void mapPartitions() { } @Test + public

[GitHub] spark pull request: SPARK-2895: Add mapPartitionsWithContext relat...

2014-09-02 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/2194#discussion_r17016552 --- Diff: core/src/test/java/org/apache/spark/JavaAPISuite.java --- @@ -708,6 +708,104 @@ public void mapPartitions() { } @Test + public

[GitHub] spark pull request: SPARK-2895: Add mapPartitionsWithContext relat...

2014-09-02 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/2194#discussion_r17016634 --- Diff: core/src/main/scala/org/apache/spark/api/java/JavaRDDLike.scala --- @@ -186,6 +186,62 @@ trait JavaRDDLike[T, This : JavaRDDLike[T, This]] extends

[GitHub] spark pull request: SPARK-2895: Add mapPartitionsWithContext relat...

2014-09-02 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/2194#discussion_r17016670 --- Diff: core/src/main/java/org/apache/spark/api/java/function/DoubleFlatMapFunction2.java --- @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: SPARK-2895: Add mapPartitionsWithContext relat...

2014-09-02 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/2194#issuecomment-54219469 @JoshRosen can you also take a look at this. It is pretty short, but it is about the java api. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: SPARK-2895: Add mapPartitionsWithContext relat...

2014-09-01 Thread ScrapCodes
Github user ScrapCodes commented on a diff in the pull request: https://github.com/apache/spark/pull/2194#discussion_r16946230 --- Diff: core/src/main/scala/org/apache/spark/api/java/JavaRDDLike.scala --- @@ -186,6 +186,56 @@ trait JavaRDDLike[T, This : JavaRDDLike[T, This]]

[GitHub] spark pull request: SPARK-2895: Add mapPartitionsWithContext relat...

2014-09-01 Thread ScrapCodes
Github user ScrapCodes commented on the pull request: https://github.com/apache/spark/pull/2194#issuecomment-54043344 It might be good to add a test suite for this in `JavaAPISuite.java`. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: SPARK-2895: Add mapPartitionsWithContext relat...

2014-09-01 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2194#issuecomment-54097265 @ChengXiangLi could you describe a bit more what the context is being used for? This is an unstable API so I'm a bit hesitant to expose this in its current form. It

[GitHub] spark pull request: SPARK-2895: Add mapPartitionsWithContext relat...

2014-09-01 Thread ChengXiangLi
Github user ChengXiangLi commented on the pull request: https://github.com/apache/spark/pull/2194#issuecomment-54102109 Hi, @pwendell , For several Hive features, such as HIVE-7843 and HIVE-7627, Hive need to access task id, no other dependency on task context currently. --- If

[GitHub] spark pull request: SPARK-2895: Add mapPartitionsWithContext relat...

2014-08-29 Thread ChengXiangLi
GitHub user ChengXiangLi opened a pull request: https://github.com/apache/spark/pull/2194 SPARK-2895: Add mapPartitionsWithContext related support on Spark Java API. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] spark pull request: SPARK-2895: Add mapPartitionsWithContext relat...

2014-08-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2194#issuecomment-53845634 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your