[GitHub] spark pull request: SPARK-4022 [CORE] [MLLIB] [WIP] Replace colt d...

2014-10-24 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/2928 SPARK-4022 [CORE] [MLLIB] [WIP] Replace colt dependency (LGPL) with commons-math This change replaces usages of colt with commons-math3 equivalents, and makes some minor necessary adjustments to

[GitHub] spark pull request: SPARK-4022 [CORE] [MLLIB] [WIP] Replace colt d...

2014-10-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2928#issuecomment-60389665 [Test build #22136 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22136/consoleFull) for PR 2928 at commit

[GitHub] spark pull request: SPARK-4022 [CORE] [MLLIB] [WIP] Replace colt d...

2014-10-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2928#issuecomment-60397795 [Test build #22136 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22136/consoleFull) for PR 2928 at commit

[GitHub] spark pull request: SPARK-4022 [CORE] [MLLIB] [WIP] Replace colt d...

2014-10-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2928#issuecomment-60397800 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-4022 [CORE] [MLLIB] [WIP] Replace colt d...

2014-10-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2928#issuecomment-60438162 [Test build #22155 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22155/consoleFull) for PR 2928 at commit

[GitHub] spark pull request: SPARK-4022 [CORE] [MLLIB] [WIP] Replace colt d...

2014-10-24 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/2928#discussion_r19362087 --- Diff: LICENSE --- @@ -1,4 +1,3 @@ - --- End diff -- The license file in Hadoop does have this empty line:

[GitHub] spark pull request: SPARK-4022 [CORE] [MLLIB] [WIP] Replace colt d...

2014-10-24 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/2928#discussion_r19362095 --- Diff: core/src/main/scala/org/apache/spark/partial/StudentTCacher.scala --- @@ -35,7 +37,8 @@ private[spark] class StudentTCacher(confidence: Double) {

[GitHub] spark pull request: SPARK-4022 [CORE] [MLLIB] [WIP] Replace colt d...

2014-10-24 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/2928#discussion_r19362101 --- Diff: core/src/main/scala/org/apache/spark/partial/SumEvaluator.scala --- @@ -55,9 +55,10 @@ private[spark] class SumEvaluator(totalOutputs: Int,

[GitHub] spark pull request: SPARK-4022 [CORE] [MLLIB] [WIP] Replace colt d...

2014-10-24 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/2928#discussion_r19362108 --- Diff: core/src/main/scala/org/apache/spark/util/random/StratifiedSamplingUtils.scala --- @@ -245,9 +245,9 @@ private[spark] object

[GitHub] spark pull request: SPARK-4022 [CORE] [MLLIB] [WIP] Replace colt d...

2014-10-24 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/2928#discussion_r19362102 --- Diff: core/src/main/scala/org/apache/spark/rdd/SampledRDD.scala --- @@ -53,9 +53,14 @@ private[spark] class SampledRDD[T: ClassTag]( if

[GitHub] spark pull request: SPARK-4022 [CORE] [MLLIB] [WIP] Replace colt d...

2014-10-24 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/2928#discussion_r19363636 --- Diff: LICENSE --- @@ -1,4 +1,3 @@ - --- End diff -- Oops, didn't mean to change that. I don't know why that happened and I'll undo it.

[GitHub] spark pull request: SPARK-4022 [CORE] [MLLIB] [WIP] Replace colt d...

2014-10-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2928#issuecomment-60447180 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-4022 [CORE] [MLLIB] [WIP] Replace colt d...

2014-10-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2928#issuecomment-60447175 [Test build #22155 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22155/consoleFull) for PR 2928 at commit

[GitHub] spark pull request: SPARK-4022 [CORE] [MLLIB] [WIP] Replace colt d...

2014-10-24 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/2928#discussion_r19364103 --- Diff: core/src/main/scala/org/apache/spark/partial/StudentTCacher.scala --- @@ -35,7 +37,8 @@ private[spark] class StudentTCacher(confidence: Double) {

[GitHub] spark pull request: SPARK-4022 [CORE] [MLLIB] [WIP] Replace colt d...

2014-10-24 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/2928#discussion_r19364277 --- Diff: core/src/main/scala/org/apache/spark/rdd/SampledRDD.scala --- @@ -53,9 +53,14 @@ private[spark] class SampledRDD[T: ClassTag]( if

[GitHub] spark pull request: SPARK-4022 [CORE] [MLLIB] [WIP] Replace colt d...

2014-10-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2928#issuecomment-60455864 [Test build #22173 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22173/consoleFull) for PR 2928 at commit

[GitHub] spark pull request: SPARK-4022 [CORE] [MLLIB] [WIP] Replace colt d...

2014-10-24 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/2928#discussion_r19368695 --- Diff: core/src/main/scala/org/apache/spark/util/random/RandomSampler.scala --- @@ -87,15 +87,19 @@ class BernoulliSampler[T](lb: Double, ub: Double,

[GitHub] spark pull request: SPARK-4022 [CORE] [MLLIB] [WIP] Replace colt d...

2014-10-24 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/2928#discussion_r19368747 --- Diff: core/src/main/scala/org/apache/spark/partial/StudentTCacher.scala --- @@ -35,7 +37,8 @@ private[spark] class StudentTCacher(confidence: Double) {

[GitHub] spark pull request: SPARK-4022 [CORE] [MLLIB] [WIP] Replace colt d...

2014-10-24 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/2928#discussion_r19368910 --- Diff: core/src/main/scala/org/apache/spark/util/random/RandomSampler.scala --- @@ -87,15 +87,19 @@ class BernoulliSampler[T](lb: Double, ub: Double,

[GitHub] spark pull request: SPARK-4022 [CORE] [MLLIB] [WIP] Replace colt d...

2014-10-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2928#issuecomment-60459439 [Test build #22176 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22176/consoleFull) for PR 2928 at commit

[GitHub] spark pull request: SPARK-4022 [CORE] [MLLIB] [WIP] Replace colt d...

2014-10-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2928#issuecomment-60460049 [Test build #22173 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22173/consoleFull) for PR 2928 at commit

[GitHub] spark pull request: SPARK-4022 [CORE] [MLLIB] [WIP] Replace colt d...

2014-10-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2928#issuecomment-60460053 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-4022 [CORE] [MLLIB] [WIP] Replace colt d...

2014-10-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2928#issuecomment-60462702 [Test build #22176 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22176/consoleFull) for PR 2928 at commit

[GitHub] spark pull request: SPARK-4022 [CORE] [MLLIB] [WIP] Replace colt d...

2014-10-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2928#issuecomment-60462708 Test FAILed. Refer to this link for build results (access rights to CI server needed):