Github user squito closed the pull request at:
https://github.com/apache/spark/pull/4048
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/4048#issuecomment-81738160
ping
Are others ambivalent about this, eg. maybe because of the complexity it
introduces to the build? If there isn't any more interest in this I'll just
close i
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4048#issuecomment-75620098
[Test build #27859 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27859/consoleFull)
for PR 4048 at commit
[`a1f1665`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4048#issuecomment-75620113
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4048#issuecomment-75604198
[Test build #27859 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27859/consoleFull)
for PR 4048 at commit
[`a1f1665`](https://githu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4048#issuecomment-71524670
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4048#issuecomment-71524664
[Test build #26101 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26101/consoleFull)
for PR 4048 at commit
[`9f125ee`](https://gith
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/4048#issuecomment-71512674
I figured out the magic combination to make sbt, scalatest, junit, and the
sbt-pom-reader all play nicely together. I had to introduce a new config (or
scope or something
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4048#issuecomment-71512525
[Test build #26101 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26101/consoleFull)
for PR 4048 at commit
[`9f125ee`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4048#issuecomment-71511610
[Test build #26100 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26100/consoleFull)
for PR 4048 at commit
[`2d6b733`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4048#issuecomment-71511623
[Test build #26100 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26100/consoleFull)
for PR 4048 at commit
[`2d6b733`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4048#issuecomment-71511628
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/4048#issuecomment-70300365
@squito yeah for sure, I think it's nice to have some set of integration
tests that are flagged as such. I was just suggesting other ways we can improve
our tests as wel
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/4048#issuecomment-70292578
@pwendell I like the idea of just getting tests to run faster in general,
but I think its gonna be hard to make that happen. (Not the most exciting
tasks for beginners an
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/4048#issuecomment-70212728
@squito another thing is that we should look at whether these tests really
need to be integration style tests or not. I've seen people often use
`local-cluster` because
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/4048#issuecomment-70181484
so, this doesn't actually work quite the way I wanted it to. It turns out
its skipping all the Junit tests as well. The junit tests are run if you run
with `test-only *
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4048#issuecomment-70024404
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4048#issuecomment-70024397
[Test build #25578 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25578/consoleFull)
for PR 4048 at commit
[`70547fa`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4048#issuecomment-70017553
[Test build #25578 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25578/consoleFull)
for PR 4048 at commit
[`70547fa`](https://githu
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/4048#issuecomment-70017200
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4048#issuecomment-70015079
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4048#issuecomment-70015071
[Test build #25576 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25576/consoleFull)
for PR 4048 at commit
[`70547fa`](https://gith
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/4048#issuecomment-70008794
@pwendell To be honest I'd never had the patience to run all the tests
before on my laptop. But I just tried them both again: 237 seconds vs. 852
seconds (just for core),
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4048#issuecomment-70008254
[Test build #25576 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25576/consoleFull)
for PR 4048 at commit
[`70547fa`](https://githu
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4048#issuecomment-69997514
This is not a terribly useful observation, but, this is what `surefire` vs
`failsafe` is for in the Maven world, without making a custom mechanism. But we
have the SBT bui
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/4048#issuecomment-69991447
Just curious - what is the before and after time? I.e. what fraction of
time does this cut down on?
---
If your project is set up for it, you can reply to this email an
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/4048#issuecomment-69990485
IIRC there are a few tests under `sql/` that use local-cluster too, but
can't name any from the top of my head.
---
If your project is set up for it, you can reply to thi
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/4048#issuecomment-69990018
oh good point Marcelo -- I forgot to add that I've only done this for
`core` in this PR. I wanted to ask others whether its worthwhile to do in
other projects or not befo
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4048#issuecomment-69988574
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/4048#issuecomment-69988816
Hey Imran, haven't looked at the code, but `YarnClusterSuite` could
probably use this tag too.
---
If your project is set up for it, you can reply to this email and have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4048#issuecomment-69988559
[Test build #25563 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25563/consoleFull)
for PR 4048 at commit
[`3a85032`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4048#issuecomment-69988571
[Test build #25563 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25563/consoleFull)
for PR 4048 at commit
[`3a85032`](https://gith
32 matches
Mail list logo
