Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3896
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/3896#issuecomment-69214673
Ok LGTM I'm merging this into master thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3896#issuecomment-69128614
[Test build #25191 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25191/consoleFull)
for PR 3896 at commit
[`65611d0`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3896#issuecomment-69128619
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3896#issuecomment-69123493
[Test build #25191 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25191/consoleFull)
for PR 3896 at commit
[`65611d0`](https://githu
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/3896#discussion_r22630087
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -105,25 +127,498 @@ private[spark] class Client(
}
/** Set up
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/3896#issuecomment-69121928
It looks like `copyFileToRemote` was a class method so that it could be
mocked for a test (Mockito can't mock static methods). There might be a more
elegant way to write t
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/3896#issuecomment-69121294
The failures are legit. Working on an update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3896#issuecomment-69120180
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3896#issuecomment-69120174
[Test build #25185 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25185/consoleFull)
for PR 3896 at commit
[`434ad3a`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3896#issuecomment-69115685
[Test build #25185 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25185/consoleFull)
for PR 3896 at commit
[`434ad3a`](https://githu
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/3896#issuecomment-69115576
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3896#discussion_r22627049
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -105,25 +127,498 @@ private[spark] class Client(
}
/** Se
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3896#issuecomment-69075003
[Test build #25167 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25167/consoleFull)
for PR 3896 at commit
[`434ad3a`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3896#issuecomment-69075015
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/3896#discussion_r22603673
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -105,25 +127,498 @@ private[spark] class Client(
}
/** Set up
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3896#issuecomment-69066983
[Test build #25167 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25167/consoleFull)
for PR 3896 at commit
[`434ad3a`](https://githu
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/3896#issuecomment-69065637
Thanks for taking a look Andrew and Tom. I tested it with both yarn-client
and yarn-cluster mode and things look fine. I originally tried making
`getApplicationReport` pr
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/3896#discussion_r22603516
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -105,25 +127,498 @@ private[spark] class Client(
}
/** Set up
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/3896#discussion_r22603093
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -17,34 +17,56 @@
package org.apache.spark.deploy.yarn
+import
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/3896#discussion_r22602942
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -17,34 +17,56 @@
package org.apache.spark.deploy.yarn
+import
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/3896#issuecomment-69039795
@sryza looks pretty straightforward to me. I notice there are a couple
methods that aren't fully private only because they're exposed for testing. If
possible, could w
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3896#discussion_r22592523
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -105,25 +127,498 @@ private[spark] class Client(
}
/** Se
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3896#discussion_r22592495
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -105,25 +127,498 @@ private[spark] class Client(
}
/** Se
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3896#discussion_r22592343
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -105,25 +127,498 @@ private[spark] class Client(
}
/** Se
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3896#discussion_r22592296
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -17,34 +17,56 @@
package org.apache.spark.deploy.yarn
+i
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3896#discussion_r22592267
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -17,34 +17,56 @@
package org.apache.spark.deploy.yarn
+i
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3896#discussion_r22592226
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -17,34 +17,56 @@
package org.apache.spark.deploy.yarn
+i
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3896#discussion_r22592139
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -105,25 +127,498 @@ private[spark] class Client(
}
/** Se
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/3896#discussion_r22588587
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -105,25 +127,498 @@ private[spark] class Client(
}
/** Set
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/3896#discussion_r22588368
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -17,34 +17,56 @@
package org.apache.spark.deploy.yarn
+im
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3896#issuecomment-68677294
[Test build #25048 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25048/consoleFull)
for PR 3896 at commit
[`930df8a`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3896#issuecomment-68677297
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3896#issuecomment-68673487
[Test build #25048 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25048/consoleFull)
for PR 3896 at commit
[`930df8a`](https://githu
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/3896#issuecomment-68673381
@andrewor14 @tgravescs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
GitHub user sryza opened a pull request:
https://github.com/apache/spark/pull/3896
SPARK-5087. [YARN] Merge yarn.Client and yarn.ClientBase
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sryza/spark sandy-spark-5087
Alternative
36 matches
Mail list logo
