Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/9860#issuecomment-160735738
Let's close this PR for now. We can always open a new PR if there's a new
approach / broader feature to discuss, but for now I don't think there's any
immediate
Github user jbonofre commented on the pull request:
https://github.com/apache/spark/pull/9860#issuecomment-160868051
Fair enough. I close the PR. Can you close the corresponding Jira please ?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jbonofre closed the pull request at:
https://github.com/apache/spark/pull/9860
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jbonofre commented on the pull request:
https://github.com/apache/spark/pull/9860#issuecomment-159876556
By the way, what do you think about discussing this on the mailing list in
order to see what the users think about this (the Apache way ;)) ?
---
If your project is
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9860#issuecomment-159879749
@jbonofre all of the messages are sent to reviews@spark.apache.org, for
those that wish to follow. Significant discussions can be pushed over to dev@
or user@, if
Github user jbonofre commented on the pull request:
https://github.com/apache/spark/pull/9860#issuecomment-159891414
Thoughts ? Do we discuss this on the mailing lists or it's worth to keep it
here and close this PR ?
---
If your project is set up for it, you can reply to this email
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/9860#issuecomment-159709314
I would prefer that we don't add this feature for now. The user can more
customized auto-refreshing on the browser than anything we can support.
---
If your project
Github user jbonofre commented on the pull request:
https://github.com/apache/spark/pull/9860#issuecomment-159709907
Fair enough. I just wait for some more hours and I will close the PR. I
think it makes sense to resolved the corresponding Jira as "won't fix".
---
If your project is
Github user jbonofre commented on the pull request:
https://github.com/apache/spark/pull/9860#issuecomment-159708041
So, what do we do about this guys ? I'm closing this PR and prepare a new
one about revamping of the UI ? Or we apply this waiting for new enhancements ?
---
If your
Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/9860#issuecomment-159237981
One thing about auto-refresh is it generates load on the back end on every
refresh, even if its a tab in the browser that isn't even visible. With a
manual
Github user jbonofre commented on the pull request:
https://github.com/apache/spark/pull/9860#issuecomment-159247914
Good point Steve. Maybe we can launch a thread on mailing list ?
Anyway, I know bunch of users doing CTRL-R or F5 again and again ;)
---
If your project is set up
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/9860#issuecomment-159084237
I'm with @JoshRosen. Also there's not really a good place to put it on the
UI and it doesn't really add any value.
---
If your project is set up for it, you can
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/9860#issuecomment-159077637
Are you sure that we want this feature? Isn't this better handled by the
user via one of the many browser extensions for auto-refresh?
I feel like this would
Github user jbonofre commented on the pull request:
https://github.com/apache/spark/pull/9860#issuecomment-159157786
I "mimic" what we have on Jenkins for instance. I understand your points
guys. I just thought it's a convenient feature for users ;)
---
If your project is set up for
Github user jbonofre commented on the pull request:
https://github.com/apache/spark/pull/9860#issuecomment-159172624
So, what do we do about this ?
First, let me go back to the checkbox (probably better IMHO in term of UI).
@JoshRosen I agree that using pushed async update
Github user jbonofre commented on the pull request:
https://github.com/apache/spark/pull/9860#issuecomment-159172833
Rebase and back on the checkbox (instead of the button).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/9860#issuecomment-159182921
I worry that this opens a can of UI / UX worms for very little net benefit
to users. For instance, a common complaint with the Jenkins auto-refresh is
that the delay
Github user jbonofre commented on the pull request:
https://github.com/apache/spark/pull/9860#issuecomment-159183472
I can add a text field to let users configure the refresh interval if you
want.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jbonofre commented on the pull request:
https://github.com/apache/spark/pull/9860#issuecomment-158863908
PR rebased and updated to use a button instead of a checkbox.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/9860#issuecomment-158425481
Wont be of much merit on the completed history server UIs, so ought to be
something which can be completely omitted off the page
---
If your project is set up
Github user jbonofre commented on the pull request:
https://github.com/apache/spark/pull/9860#issuecomment-158377000
Thanks for the update Sean. Some background:
1. I wanted to avoid "intrusive" code on the server side, that's why the
refresh is "client side" using JavaScript.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9860#issuecomment-158375239
I kind of like the functionality, myself. However I'm only concerned about
where and how to expose this. I want to avoid tacking on bits and pieces to the
UI until it's
Github user jbonofre commented on the pull request:
https://github.com/apache/spark/pull/9860#issuecomment-158373980
Rebase
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user jbonofre opened a pull request:
https://github.com/apache/spark/pull/9860
SPARK-5106 - Add refresh checkbox on the UI
Add a checkbox to enable auto-refresh. See attached screenshots:
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9860#issuecomment-158373998
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/9860#issuecomment-158492790
this feels more like a button thing than a checkbox thing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user jbonofre commented on the pull request:
https://github.com/apache/spark/pull/9860#issuecomment-158592705
@andrewor14 I can change to a link or button (instead of a checkbox), no
worries.
@steveloughran agree, I changed in UIUtils to be global. I can add a flag
in
27 matches
Mail list logo
