GitHub user steveloughran opened a pull request:
https://github.com/apache/spark/pull/5119
SPARK-6433 patch 001: test JARs are built; sql/hive pulls in spark-sql &...
1. Test JARs are built & published
1. log4j.resources is explicitly excluded. Without this, downstream test
run logging depends on the order the JARs are listed/loaded
1. sql/hive pulls in spark-sql &...spark-catalyst for its test runs
1. The copied in test classes were rm'd, and a test edited to remove its
now duplicate assert method
1. Spark streaming is now build with the same plugin/phase as the rest, but
its shade plugin declaration is kept in (so different from the rest of the test
plugins). Due to (#2), this means the test JAR no longer includes its log4j
file.
Outstanding issues:
* should the JARs be shaded? `spark-streaming-test.jar` does, but given
these are test jars for developers only, especially in the same spark source
tree, it's hard to justify.
* `maven-jar-plugin` v 2.6 was explicitly selected; without this the
apache-1.4 parent template JAR version (2.4) chosen.
* Are there any other resources to exclude?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/steveloughran/spark
stevel/patches/SPARK-6433-test-jars
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5119.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5119
----
commit 650f4420d22ddbc516727ae22c0ce73b37781465
Author: Steve Loughran <ste...@hortonworks.com>
Date: 2015-03-21T20:12:19Z
SPARK-6433 patch 001: test JARs are built; sql/hive pulls in spark-sql &
spark-catalyst for its test runs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
