[GitHub] spark pull request: SPARK-7063 when lz4 compression is used, it ca...

2015-05-18 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5641#issuecomment-102940913 (That's fine -- you can also just rebase and force-push the existing branch/PR. The advantage there is that it retains the discussion in a single PR. But no big deal

[GitHub] spark pull request: Spark-7063 when lz4 compression is used, it ca...

2015-05-18 Thread JihongMA
Github user JihongMA commented on the pull request: https://github.com/apache/spark/pull/6226#issuecomment-103219142 sorry, it is done now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Spark-7063 when lz4 compression is used, it ca...

2015-05-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/6226 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: SPARK-7063 when lz4 compression is used, it ca...

2015-05-17 Thread JihongMA
Github user JihongMA closed the pull request at: https://github.com/apache/spark/pull/5641 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: SPARK-7063 when lz4 compression is used, it ca...

2015-05-17 Thread JihongMA
Github user JihongMA commented on the pull request: https://github.com/apache/spark/pull/5641#issuecomment-102902698 sorry, I was busy and missed this message. I created a new pull request, which rebased the change with latest master. --- If your project is set up for it, you can

[GitHub] spark pull request: SPARK-7063 when lz4 compression is used, it ca...

2015-05-15 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5641#issuecomment-102364796 @JihongMA this needs a rebase now, and has an unrelated change? if you make it just about updating the lz4 version, I'll merge it for master. --- If your project is set

[GitHub] spark pull request: SPARK-7063 when lz4 compression is used, it ca...

2015-04-27 Thread linlin200605
Github user linlin200605 commented on the pull request: https://github.com/apache/spark/pull/5641#issuecomment-96861052 I just found out there are changes introduced in 1.3.0 which are not backward compatible with JDK6, if supporting JDK6 is a must, then we can consider to target it

[GitHub] spark pull request: SPARK-7063 when lz4 compression is used, it ca...

2015-04-27 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5641#issuecomment-96774945 @linlin200605 any update on this? java 7 bytecode can't even be loaded in java 6. It's not an API question. If not we have to close this I'm afraid or at least target it

[GitHub] spark pull request: SPARK-7063 when lz4 compression is used, it ca...

2015-04-27 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/5641#issuecomment-96780950 @srowen yeah maybe let's close this as a won't fix and just give the workaround for IBM users to upgrade the dependency themselves. --- If your project is set up for

[GitHub] spark pull request: SPARK-7063 when lz4 compression is used, it ca...

2015-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5641#issuecomment-96766769 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-7063 when lz4 compression is used, it ca...

2015-04-23 Thread linlin200605
Github user linlin200605 commented on the pull request: https://github.com/apache/spark/pull/5641#issuecomment-95674803 lz4-1.3.0 needs Java 7 for building the jar, usually not necessarily require JDK 7 at runtime if there is backward compatibility. I will follow up on that. --- If

[GitHub] spark pull request: SPARK-7063 when lz4 compression is used, it ca...

2015-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5641#issuecomment-95462973 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-7063 when lz4 compression is used, it ca...

2015-04-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5641#issuecomment-95462960 [Test build #30806 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30806/consoleFull) for PR 5641 at commit

[GitHub] spark pull request: SPARK-7063 when lz4 compression is used, it ca...

2015-04-23 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5641#issuecomment-95522827 Looks like this requires Java 7? https://github.com/jpountz/lz4-java/commits/master We can't use it if so, but, the tests passed anyway. It looks like a lot

[GitHub] spark pull request: SPARK-7063 when lz4 compression is used, it ca...

2015-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5641#issuecomment-95395862 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-7063 when lz4 compression is used, it ca...

2015-04-22 Thread linlin200605
GitHub user linlin200605 opened a pull request: https://github.com/apache/spark/pull/5641 SPARK-7063 when lz4 compression is used, it causes core dump please review this pull request. Thank you! You can merge this pull request into a Git repository by running: $ git pull

[GitHub] spark pull request: SPARK-7063 when lz4 compression is used, it ca...

2015-04-22 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/5641#issuecomment-95422599 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-7063 when lz4 compression is used, it ca...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5641#issuecomment-95423349 [Test build #30806 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30806/consoleFull) for PR 5641 at commit