[GitHub] spark pull request: SPARK-7889 Jobs progress of apps on complete p...

2015-06-29 Thread steveloughran
Github user steveloughran commented on the pull request: https://github.com/apache/spark/pull/6935#issuecomment-116592795 I like the selenium test; it could be combined with the provider i wrote which lets us programmatically create our own history, so add changes we can look for.

[GitHub] spark pull request: SPARK-7889 Jobs progress of apps on complete p...

2015-06-29 Thread steveloughran
Github user steveloughran commented on the pull request: https://github.com/apache/spark/pull/6935#issuecomment-116795511 (BTW, I'm not going to be looking at this for a couple of weeks; focusing on a (big) patch --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: SPARK-7889 Jobs progress of apps on complete p...

2015-06-28 Thread XuTingjun
Github user XuTingjun commented on the pull request: https://github.com/apache/spark/pull/6935#issuecomment-116374449 @squito, I am agree with what you said. First about my patch[#6545](https://github.com/apache/spark/pull/6545/files), it will refresh only on request

[GitHub] spark pull request: SPARK-7889 Jobs progress of apps on complete p...

2015-06-28 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/6935#issuecomment-116390029 @steveloughran do you think you can pick this up with the test case? I think we have a little better understanding of the problem. I do think your approach is in the

[GitHub] spark pull request: SPARK-7889 Jobs progress of apps on complete p...

2015-06-28 Thread XuTingjun
Github user XuTingjun commented on the pull request: https://github.com/apache/spark/pull/6935#issuecomment-116404740 yeah, I think this patch also can't refresh. The place where detache the handlers is not right. I think we need to thinking when and where to detache the handlers.

[GitHub] spark pull request: SPARK-7889 Jobs progress of apps on complete p...

2015-06-26 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/6935#issuecomment-115742256 @steveloughran @XuTingjun sorry I finally took a closer look here. So I tried running a manual test on this patch and https://github.com/apache/spark/pull/6545, and

[GitHub] spark pull request: SPARK-7889 Jobs progress of apps on complete p...

2015-06-26 Thread steveloughran
Github user steveloughran commented on the pull request: https://github.com/apache/spark/pull/6935#issuecomment-115744548 If you want to do tests, grab the code *

[GitHub] spark pull request: SPARK-7889 Jobs progress of apps on complete p...

2015-06-26 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/6935#issuecomment-115849879 sorry I didn't see that comment about the tests ... I wrote something up which mimics the existing `UISeleniumSuite`. ```scala From

[GitHub] spark pull request: SPARK-7889 Jobs progress of apps on complete p...

2015-06-26 Thread steveloughran
Github user steveloughran commented on the pull request: https://github.com/apache/spark/pull/6935#issuecomment-115622133 I probably tested different bits of it ... I verified that updated apps were coming in, but no, not a full functional test of the Web UI, as that would take a lot

[GitHub] spark pull request: SPARK-7889 Jobs progress of apps on complete p...

2015-06-25 Thread XuTingjun
Github user XuTingjun commented on the pull request: https://github.com/apache/spark/pull/6935#issuecomment-115131256 @steveloughran Have you tested it? I don't think it's ok. yeah, you realized the refreshing of incompleted apps. But I think second time sending /history/appid

[GitHub] spark pull request: SPARK-7889 Jobs progress of apps on complete p...

2015-06-25 Thread sujkh85
Github user sujkh85 commented on the pull request: https://github.com/apache/spark/pull/6935#issuecomment-115131325 NAVER - http://www.naver.com/ su...@naver.com 님께 보내신 메일 Re: [spark] SPARK-7889 Jobs progress

[GitHub] spark pull request: SPARK-7889 Jobs progress of apps on complete p...

2015-06-23 Thread steveloughran
Github user steveloughran commented on the pull request: https://github.com/apache/spark/pull/6935#issuecomment-114656473 I should add that I did think about actually using the last-updated information to decide whether to refresh or not, and decided simply having a timeout was a

[GitHub] spark pull request: SPARK-7889 Jobs progress of apps on complete p...

2015-06-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6935#issuecomment-114137546 [Test build #35453 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35453/consoleFull) for PR 6935 at commit

[GitHub] spark pull request: SPARK-7889 Jobs progress of apps on complete p...

2015-06-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6935#issuecomment-114137954 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-7889 Jobs progress of apps on complete p...

2015-06-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6935#issuecomment-114138112 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: SPARK-7889 Jobs progress of apps on complete p...

2015-06-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6935#issuecomment-114138077 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: SPARK-7889 Jobs progress of apps on complete p...

2015-06-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6935#issuecomment-114138421 [Test build #35454 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35454/consoleFull) for PR 6935 at commit

[GitHub] spark pull request: SPARK-7889 Jobs progress of apps on complete p...

2015-06-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6935#issuecomment-114138899 [Test build #35454 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35454/console) for PR 6935 at commit

[GitHub] spark pull request: SPARK-7889 Jobs progress of apps on complete p...

2015-06-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6935#issuecomment-114138905 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-7889 Jobs progress of apps on complete p...

2015-06-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6935#issuecomment-114137950 [Test build #35453 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35453/console) for PR 6935 at commit

[GitHub] spark pull request: SPARK-7889 Jobs progress of apps on complete p...

2015-06-22 Thread steveloughran
Github user steveloughran commented on the pull request: https://github.com/apache/spark/pull/6935#issuecomment-114253979 `CacheEntry` is unintentional public class; will fix. I have no idea where the others came from --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: SPARK-7889 Jobs progress of apps on complete p...

2015-06-22 Thread steveloughran
Github user steveloughran commented on the pull request: https://github.com/apache/spark/pull/6935#issuecomment-114254408 style check. Not enough spaces, by the look of things ``` [error]

[GitHub] spark pull request: SPARK-7889 Jobs progress of apps on complete p...

2015-06-22 Thread XuTingjun
Github user XuTingjun commented on the pull request: https://github.com/apache/spark/pull/6935#issuecomment-114329092 @steveloughran, I think you always put too many space in some place. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: SPARK-7889 Jobs progress of apps on complete p...

2015-06-22 Thread steveloughran
GitHub user steveloughran opened a pull request: https://github.com/apache/spark/pull/6935 SPARK-7889 Jobs progress of apps on complete page of HistoryServer shows uncompleted This patch pulls all the application cache logic out of the `HistoryServer` and into its own

[GitHub] spark pull request: SPARK-7889 Jobs progress of apps on complete p...

2015-06-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6935#issuecomment-114136875 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: SPARK-7889 Jobs progress of apps on complete p...

2015-06-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6935#issuecomment-114136859 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not