[GitHub] spark pull request: Scala version switching build enhancements

2015-06-16 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/6832#issuecomment-112522218 One JIRA is fine. Yes I see the same problem with OS X `sed`, so falling back to `gsed` is probably good. --- If your project is set up for it, you can reply to this ema

[GitHub] spark pull request: Scala version switching build enhancements

2015-06-16 Thread mallman
Github user mallman commented on the pull request: https://github.com/apache/spark/pull/6832#issuecomment-112478712 @srowen Should I create one Jira ticket for this or multiple? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] spark pull request: Scala version switching build enhancements

2015-06-16 Thread mallman
Github user mallman commented on the pull request: https://github.com/apache/spark/pull/6832#issuecomment-112477102 @srowen Will create a Jira ticket. @ScrapCodes This is what I get with (presumably BSD) sed on OS X: ``` [msa@Michaels-MacBook-Pro spark-1.4]$ ./dev/

[GitHub] spark pull request: Scala version switching build enhancements

2015-06-15 Thread ScrapCodes
Github user ScrapCodes commented on the pull request: https://github.com/apache/spark/pull/6832#issuecomment-112308999 I am Ok with 1. Is there a reason we should restrict ourselves to GNU SED ? I suppose our scripts were posix complaint. --- If your project is set up for i

[GitHub] spark pull request: Scala version switching build enhancements

2015-06-15 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/6832#issuecomment-112306270 @mallman Have a look at https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark please CC @ScrapCodes --- If your project is set up for it, you

[GitHub] spark pull request: Scala version switching build enhancements

2015-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6832#issuecomment-112243794 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: Scala version switching build enhancements

2015-06-15 Thread mallman
GitHub user mallman opened a pull request: https://github.com/apache/spark/pull/6832 Scala version switching build enhancements These commits address a few minor issues in the Scala cross-version support in the build: 1. Correct two missing `${scala.binary.version}` pom f