[GitHub] spark pull request: Spark SQL basicOperators add Except operator

2014-06-21 Thread YanjieGao
Github user YanjieGao commented on the pull request: https://github.com/apache/spark/pull/1151#issuecomment-46754425 Hi Zongheng, I try it ,and try add code like other operator. I don't know if i want to add this except operator ,do i need to add code or modify code in other scala

[GitHub] spark pull request: Spark SQL basicOperators add Except operator

2014-06-21 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/1151#discussion_r14051137 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala --- @@ -204,3 +204,18 @@ case class ExistingRdd(output:

[GitHub] spark pull request: Spark SQL basicOperators add Except operator

2014-06-21 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/1151#discussion_r14051147 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala --- @@ -204,3 +204,18 @@ case class ExistingRdd(output:

[GitHub] spark pull request: Spark SQL basicOperators add Except operator

2014-06-21 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/1151#issuecomment-46761858 Thanks for working on this! A few remaining tasks: - [ ] Add a new logical operator in `basicOperators.scala` in `catalyst/...`. - [ ] Hook that new

[GitHub] spark pull request: Spark SQL basicOperators add Except operator

2014-06-21 Thread YanjieGao
Github user YanjieGao commented on the pull request: https://github.com/apache/spark/pull/1151#issuecomment-46769120 Thanks a lot , It's very nice of you .I will work around it .And then add code in the other files .I have some problems about some syntax .I have sent a mail to

[GitHub] spark pull request: Spark SQL basicOperators add Except operator

2014-06-20 Thread concretevitamin
Github user concretevitamin commented on the pull request: https://github.com/apache/spark/pull/1151#issuecomment-46732664 For this to take effects, the parser (`SQLParser`) needs to be changed to be able to parse EXCEPT return the correct operators. --- If your project is set up