Github user jaceklaskowski commented on the pull request:
https://github.com/apache/spark/pull/9501#issuecomment-154572569
Thanks again @srowen! Next pull req should be from starter tag.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9501#issuecomment-154348664
Typos, maybe, or doc fixes. Some of these aren't fixes, or are just
whitespace changes. It's not worth the time, really, unless you're cleaning up
along the way to
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9501#issuecomment-154349622
**[Test build #1996 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1996/consoleFull)**
for PR 9501 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9501#issuecomment-154383561
**[Test build #1996 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1996/consoleFull)**
for PR 9501 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9501#issuecomment-154518300
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9501
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/9501
Typo fixes + code readability improvements
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jaceklaskowski/spark typos-with-style
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9501#discussion_r44064323
--- Diff: core/src/main/scala/org/apache/spark/rdd/HadoopRDD.scala ---
@@ -195,9 +196,6 @@ class HadoopRDD[K, V](
// add the credentials here as this
Github user jaceklaskowski commented on the pull request:
https://github.com/apache/spark/pull/9501#issuecomment-154199308
Thanks @srowen for reviewing the changes. They indeed are small since
they're the outcome of me going through the code and learning Spark this way.
When I run
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9501#issuecomment-154180634
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9501#issuecomment-154180340
Except one comment, all the changes look fine, but I'm not sure I think
it's a great use of time. Most of these are very marginal clarifications or
spacing fixes. I'd
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/9501#discussion_r44071949
--- Diff: core/src/main/scala/org/apache/spark/rdd/HadoopRDD.scala ---
@@ -195,9 +196,6 @@ class HadoopRDD[K, V](
// add the credentials here
12 matches
Mail list logo
