Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/588#issuecomment-42494038
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/588
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/588#issuecomment-42494227
Merged, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/588#issuecomment-42252972
@srowen They are the same because in `Vectors.dense(first: Double, others:
Double*)` defined, we use `first +: others.toArray` and `toArray` does not copy
the data. But it
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/588#issuecomment-42212912
(I'd be curious to know why this might or might not be faster, if someone
has the time to sketch an explanation. I don't doubt it might be.)
---
If your project is set up
Github user baishuo commented on the pull request:
https://github.com/apache/spark/pull/588#issuecomment-42211095
Hi guys @mengxr @techaddict , Is there something need to do before merge? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/588#issuecomment-41764996
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/588#issuecomment-41764997
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14581/
---
If your project is set up for it, you can r
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/588#issuecomment-41761073
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/588#issuecomment-41761067
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/588#issuecomment-41761064
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user baishuo commented on the pull request:
https://github.com/apache/spark/pull/588#issuecomment-41755330
had modified, thanks to @techaddict @mengxr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user techaddict commented on the pull request:
https://github.com/apache/spark/pull/588#issuecomment-41709531
@baishuo change it to `Vectors.dense(1.0 +: features.toArray)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user baishuo commented on the pull request:
https://github.com/apache/spark/pull/588#issuecomment-41705910
I had modify the code to Vectors.dense(1.0 +: features) .
can some setting can make this code compile successful? @mengxr
---
If your project is set up for it, you
Github user techaddict commented on the pull request:
https://github.com/apache/spark/pull/588#issuecomment-41699346
@mengxr yupp that would be better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user techaddict commented on a diff in the pull request:
https://github.com/apache/spark/pull/588#discussion_r12102704
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/optimization/GradientDescentSuite.scala
---
@@ -81,11 +81,11 @@ class GradientDescentSuite extends Fu
Github user techaddict commented on a diff in the pull request:
https://github.com/apache/spark/pull/588#discussion_r12102671
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/optimization/GradientDescentSuite.scala
---
@@ -81,11 +81,11 @@ class GradientDescentSuite extends Fu
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/588#issuecomment-41698810
Should use `Vectors.dense(1.0 +: features)`, which may be faster than
`Vectors.dense(1.0, features: _*)`, depending on how scala compiles the code.
---
If your project is
Github user techaddict commented on the pull request:
https://github.com/apache/spark/pull/588#issuecomment-41685020
IMHO this will not compile if used like this `1 +: features`, Integers with
DenseVector[Double]. Are you sure we want this change ?
---
If your project is set up for i
Github user techaddict commented on the pull request:
https://github.com/apache/spark/pull/588#issuecomment-41684218
I think we want to use Dense Vector's instead of Arrays in Mllib.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/588#issuecomment-41673127
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user baishuo closed the pull request at:
https://github.com/apache/spark/pull/256
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user baishuo commented on the pull request:
https://github.com/apache/spark/pull/256#issuecomment-41673035
Hi @mengxr the new PR is https://github.com/apache/spark/pull/588 please
go to see if it can merge, thank you .
close this PR
---
If your project is set up for it
GitHub user baishuo opened a pull request:
https://github.com/apache/spark/pull/588
Update GradientDescentSuite.scala
use more faster way to construct an array
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/baishuo/spark master
Github user baishuo commented on the pull request:
https://github.com/apache/spark/pull/256#issuecomment-41657234
no problem @mengxr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/256#issuecomment-41649510
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14559/
---
If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/256#issuecomment-41649507
Build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/256#issuecomment-41647624
@baishuo This is no longer mergeable. Could you try to merge the latest
master?
---
If your project is set up for it, you can reply to this email and have your
reply appea
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/256#issuecomment-41646349
Build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/256#issuecomment-41646353
Build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/256#issuecomment-41646208
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/256#issuecomment-38881820
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/256#issuecomment-38815469
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
GitHub user baishuo opened a pull request:
https://github.com/apache/spark/pull/256
Update GradientDescentSuite.scala
use more faster way to construct an Array
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/baishuo/spark bbb
Alt
34 matches
Mail list logo
