[GitHub] spark pull request: Update RecoverableNetworkWordCount.scala

2014-11-10 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/2735#discussion_r20106873 --- Diff: examples/src/main/scala/org/apache/spark/examples/streaming/RecoverableNetworkWordCount.scala --- @@ -114,7 +115,7 @@ object

[GitHub] spark pull request: Update RecoverableNetworkWordCount.scala

2014-11-10 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/2735#issuecomment-62442543 @comcmipi Yes, in the current version, if you quit the streaming application (aka driver) quits, then the data received by receivers but not yet processed gets lost. Thats

[GitHub] spark pull request: Update RecoverableNetworkWordCount.scala

2014-11-10 Thread comcmipi
Github user comcmipi commented on the pull request: https://github.com/apache/spark/pull/2735#issuecomment-62448101 @tdas Thanks for clarifying it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: Update RecoverableNetworkWordCount.scala

2014-11-10 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/2735#discussion_r20109983 --- Diff: examples/src/main/scala/org/apache/spark/examples/streaming/RecoverableNetworkWordCount.scala --- @@ -114,7 +115,7 @@ object

[GitHub] spark pull request: Update RecoverableNetworkWordCount.scala

2014-11-10 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/2735#issuecomment-62450003 Tested this manually, works perfectly. Merging this. Thanks for this! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: Update RecoverableNetworkWordCount.scala

2014-11-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2735 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: Update RecoverableNetworkWordCount.scala

2014-11-09 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/2735#discussion_r20057909 --- Diff: examples/src/main/scala/org/apache/spark/examples/streaming/RecoverableNetworkWordCount.scala --- @@ -114,7 +115,7 @@ object

[GitHub] spark pull request: Update RecoverableNetworkWordCount.scala

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2735#issuecomment-62252431 [Test build #23097 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23097/consoleFull) for PR 2735 at commit

[GitHub] spark pull request: Update RecoverableNetworkWordCount.scala

2014-11-08 Thread comcmipi
Github user comcmipi commented on the pull request: https://github.com/apache/spark/pull/2735#issuecomment-62252538 There is one more issue in this example. It could be the lack of my understanding, or maybe a problem. When the checkpoint exists and you send some lines to nc

[GitHub] spark pull request: Update RecoverableNetworkWordCount.scala

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2735#issuecomment-62254523 [Test build #23097 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23097/consoleFull) for PR 2735 at commit

[GitHub] spark pull request: Update RecoverableNetworkWordCount.scala

2014-11-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2735#issuecomment-62254525 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: Update RecoverableNetworkWordCount.scala

2014-11-07 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/2735#discussion_r20040175 --- Diff: examples/src/main/scala/org/apache/spark/examples/streaming/RecoverableNetworkWordCount.scala --- @@ -116,6 +116,7 @@ object

[GitHub] spark pull request: Update RecoverableNetworkWordCount.scala

2014-11-07 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/2735#issuecomment-62221232 Thank you for catching this. The example is almost useless without that! I had one comment, please address that. Other than I tested the change manually (since unit tests

[GitHub] spark pull request: Update RecoverableNetworkWordCount.scala

2014-11-07 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/2735#issuecomment-62221302 Also, please make a JIRA and update the title with the JIRA (see other pull requests) --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: Update RecoverableNetworkWordCount.scala

2014-11-07 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/2735#issuecomment-62231450 I made this change in https://github.com/apache/spark/pull/2564 too. You could kinda think of this as part of the SPARK-2548 JIRA as well as it includes some touch-ups to

[GitHub] spark pull request: Update RecoverableNetworkWordCount.scala

2014-10-23 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/2735#issuecomment-60316389 Jenkins, this is ok to test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Update RecoverableNetworkWordCount.scala

2014-10-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2735#issuecomment-60316955 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22089/consoleFull) for PR 2735 at commit

[GitHub] spark pull request: Update RecoverableNetworkWordCount.scala

2014-10-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2735#issuecomment-60324050 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22089/consoleFull) for PR 2735 at commit

[GitHub] spark pull request: Update RecoverableNetworkWordCount.scala

2014-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2735#issuecomment-60324055 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: Update RecoverableNetworkWordCount.scala

2014-10-14 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/2735#issuecomment-59119147 @tdas --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: Update RecoverableNetworkWordCount.scala

2014-10-09 Thread comcmipi
GitHub user comcmipi opened a pull request: https://github.com/apache/spark/pull/2735 Update RecoverableNetworkWordCount.scala Trying this example, I missed the moment when the checkpoint was iniciated You can merge this pull request into a Git repository by running: $ git

[GitHub] spark pull request: Update RecoverableNetworkWordCount.scala

2014-10-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2735#issuecomment-58522723 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your