[GitHub] spark pull request: Update the command to use IPython notebook

2015-03-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/5111 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: Update the command to use IPython notebook

2015-03-24 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5111#issuecomment-85485820 OK I merged this with a couple fixes to the text (e.g. spark - Spark) --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: Update the command to use IPython notebook

2015-03-24 Thread yuecong
Github user yuecong commented on the pull request: https://github.com/apache/spark/pull/5111#issuecomment-85567072 Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: Update the command to use IPython notebook

2015-03-23 Thread yuecong
Github user yuecong commented on the pull request: https://github.com/apache/spark/pull/5111#issuecomment-85060322 It is the IPython 3.0. I believe one of the motivation of IPython notebook is their chart drawing functionality. This is the reason why pylab library is specially

[GitHub] spark pull request: Update the command to use IPython notebook

2015-03-23 Thread yuecong
Github user yuecong commented on the pull request: https://github.com/apache/spark/pull/5111#issuecomment-85153146 The notebook UI is different between 2.4 and new 3.0. But %pylab inline both work for 2.4 and 3.0 version. I agree that we do not need to explain how to launch a

[GitHub] spark pull request: Update the command to use IPython notebook

2015-03-23 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5111#issuecomment-85156026 OK, if this isn't making the example unusable for reasonably recent versions of ipython then it seems OK. Oh, above I was not suggesting that you remove your additional

[GitHub] spark pull request: Update the command to use IPython notebook

2015-03-23 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5111#issuecomment-85198759 OK, nevermind my question. I think it's clear you know what to do here and it's as you think it should be. I'll leave it open a bit for any other opinions but if it's

[GitHub] spark pull request: Update the command to use IPython notebook

2015-03-23 Thread yuecong
Github user yuecong commented on the pull request: https://github.com/apache/spark/pull/5111#issuecomment-85188711 Let me clarify my opinions more clearly. 1, change '$ PYSPARK_DRIVER_PYTHON=ipython PYSPARK_DRIVER_PYTHON_OPTS=notebook --pylab inline ./bin/pyspark' to $

[GitHub] spark pull request: Update the command to use IPython notebook

2015-03-23 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5111#issuecomment-85116122 But does this then work with ipython 2? I wouldn't want to necessarily 'break' support, even if it's just in an example. Or are two examples called for? Ideally, one

[GitHub] spark pull request: Update the command to use IPython notebook

2015-03-21 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/5111#discussion_r26895623 --- Diff: docs/programming-guide.md --- @@ -237,9 +237,11 @@ You can customize the `ipython` command by setting `PYSPARK_DRIVER_PYTHON_OPTS`. the

[GitHub] spark pull request: Update the command to use IPython notebook

2015-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5111#issuecomment-84195814 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: Update the command to use IPython notebook

2015-03-20 Thread yuecong
GitHub user yuecong opened a pull request: https://github.com/apache/spark/pull/5111 Update the command to use IPython notebook As for notebook --pylab inline is not supported any more, update the related documentation for this. You can merge this pull request into a Git