[GitHub] spark pull request: remove unnecessary copy

2015-11-30 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10040#issuecomment-160747994 I actually think this PR should just be closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: remove unnecessary copy

2015-11-30 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10040#issuecomment-160746981 need JIRA --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: remove unnecessary copy

2015-11-30 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/10040#issuecomment-160749555 Yeah, this doesn't have a description / explanation of changes, JIRA ticket, _or_ benchmark results. Let's close for now. --- If your project is set up for it, you

[GitHub] spark pull request: remove unnecessary copy

2015-11-30 Thread viper-kun
Github user viper-kun commented on the pull request: https://github.com/apache/spark/pull/10040#issuecomment-160824966 ok.close it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: remove unnecessary copy

2015-11-30 Thread viper-kun
Github user viper-kun closed the pull request at: https://github.com/apache/spark/pull/10040 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: remove unnecessary copy

2015-11-30 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10040#issuecomment-160621034 If this is an optimization, it's a very small one. Are you sure it improves things? weirdly, I've found this kind of thing can slow down very tight loops since you put

[GitHub] spark pull request: remove unnecessary copy

2015-11-30 Thread viper-kun
GitHub user viper-kun opened a pull request: https://github.com/apache/spark/pull/10040 remove unnecessary copy You can merge this pull request into a Git repository by running: $ git pull https://github.com/viper-kun/spark patch-1 Alternatively you can review and apply

[GitHub] spark pull request: remove unnecessary copy

2015-11-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10040#issuecomment-160619389 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: remove unnecessary copy

2015-11-30 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/10040#issuecomment-160621899 It's not a deep copy, just assign a new reference which is very cheap, and I'm afraid your extra if branch may hurt the performance. --- If your project is set up