[GitHub] spark pull request #13269: [SPARK-15494][SQL] encoder code cleanup

2016-06-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13269 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #13269: [SPARK-15494][SQL] encoder code cleanup

2016-06-02 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/13269#discussion_r65638928 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1884,10 +1884,63 @@ class Analyzer( } e

[GitHub] spark pull request #13269: [SPARK-15494][SQL] encoder code cleanup

2016-06-02 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/13269#discussion_r65638864 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1884,10 +1884,63 @@ class Analyzer( } e

[GitHub] spark pull request #13269: [SPARK-15494][SQL] encoder code cleanup

2016-06-02 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/13269#discussion_r65639249 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala --- @@ -191,6 +189,26 @@ case class ExpressionEncoder

[GitHub] spark pull request #13269: [SPARK-15494][SQL] encoder code cleanup

2016-06-02 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/13269#discussion_r65637841 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1884,10 +1884,63 @@ class Analyzer( } e

[GitHub] spark pull request #13269: [SPARK-15494][SQL] encoder code cleanup

2016-06-02 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/13269#discussion_r65637799 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1884,10 +1884,63 @@ class Analyzer( } e

[GitHub] spark pull request #13269: [SPARK-15494][SQL] encoder code cleanup

2016-06-02 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/13269#discussion_r65492813 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1884,10 +1884,62 @@ class Analyzer( } e

[GitHub] spark pull request #13269: [SPARK-15494][SQL] encoder code cleanup

2016-06-01 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/13269#discussion_r65492290 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1884,10 +1884,62 @@ class Analyzer( } e

[GitHub] spark pull request #13269: [SPARK-15494][SQL] encoder code cleanup

2016-06-01 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/13269#discussion_r65485798 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/Encoders.scala --- @@ -208,7 +209,7 @@ object Encoders { BoundReference(0, Object

[GitHub] spark pull request #13269: [SPARK-15494][SQL] encoder code cleanup

2016-06-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13269#discussion_r65462283 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala --- @@ -191,6 +189,26 @@ case class ExpressionEncoder

[GitHub] spark pull request #13269: [SPARK-15494][SQL] encoder code cleanup

2016-06-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13269#discussion_r65462066 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/Encoders.scala --- @@ -208,7 +209,7 @@ object Encoders { BoundReference(0, Object

[GitHub] spark pull request #13269: [SPARK-15494][SQL] encoder code cleanup

2016-06-01 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/13269#discussion_r65460601 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/Encoders.scala --- @@ -208,7 +209,7 @@ object Encoders { BoundReference(0, Object