Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13418
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13418#discussion_r65609442
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala
---
@@ -123,6 +123,31 @@ class SubquerySuite extends QueryTest with
SharedSQLCo
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13418#discussion_r65609083
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala
---
@@ -123,6 +123,31 @@ class SubquerySuite extends QueryTest with
SharedSQLCo
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13418#discussion_r65594703
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala
---
@@ -121,6 +123,16 @@ class SubquerySuite extends QueryTest with
SharedSQLCo
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13418#discussion_r65484867
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1468,10 +1468,15 @@ object DecimalAggregates extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13418#discussion_r65455758
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1468,7 +1468,8 @@ object DecimalAggregates extends R
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/13418#discussion_r65441184
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1468,7 +1468,8 @@ object DecimalAggregates extends Rule
Github user ioana-delaney commented on a diff in the pull request:
https://github.com/apache/spark/pull/13418#discussion_r65438111
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -84,6 +84,13 @@ object ScalarSubquery {
Github user ioana-delaney commented on a diff in the pull request:
https://github.com/apache/spark/pull/13418#discussion_r65437967
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1468,7 +1468,8 @@ object DecimalAggregates exten
