GitHub user javabrett opened a pull request:
https://github.com/apache/spark/pull/13462
Fixed local-timezone-brittle test where short-timezone form "EST" is â¦
## What changes were proposed in this pull request?
Stop using the abbreviated and ambiguous timezone "EST" in a test, since it
is machine-local default timezone dependent, and fails in different timezones.
Fixed [SPARK-15723](https://issues.apache.org/jira/browse/SPARK-15723).
## How was this patch tested?
Note that to reproduce this problem in any locale/timezone, you can modify
the scalatest-maven-plugin argLine to add a timezone:
<argLine>-ea -Xmx3g -XX:MaxPermSize=${MaxPermGen}
-XX:ReservedCodeCacheSize=${CodeCacheSize}
-Duser.timezone="Australia/Sydney"</argLine>
and run
$ mvn test
-DwildcardSuites=org.apache.spark.status.api.v1.SimpleDateParamSuite
-Dtest=none. Equally this will fix it in an effected timezone:
<argLine>-ea -Xmx3g -XX:MaxPermSize=${MaxPermGen}
-XX:ReservedCodeCacheSize=${CodeCacheSize}
-Duser.timezone="America/New_York"</argLine>
To test the fix, apply the above change to `pom.xml` to set test TZ to
`Australia/Sydney`, and confirm the test now passes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/javabrett/spark
SPARK-15723-SimpleDateParamSuite
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/13462.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13462
----
commit 7dfc17b0b91c177dfa30a692925e644443726c90
Author: Brett Randall <javabr...@gmail.com>
Date: 2016-06-02T03:44:19Z
Fixed local-timezone-brittle test where short-timezone form "EST" is
ambiguous. Use -0500 instead. Fixed SPARK-15723.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
