[GitHub] spark pull request #13534: [SPARK-15789][SQL] Allow reserved keywords in mos...

2016-06-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13534 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #13534: [SPARK-15789][SQL] Allow reserved keywords in mos...

2016-06-07 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/13534#discussion_r66171754 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DataTypeParserSuite.scala --- @@ -133,4 +133,8 @@ class CatalystQlDataTypeParserSui

[GitHub] spark pull request #13534: [SPARK-15789][SQL] Allow reserved keywords in mos...

2016-06-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13534#discussion_r66170917 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DataTypeParserSuite.scala --- @@ -133,4 +133,8 @@ class CatalystQlDataTypeParse

[GitHub] spark pull request #13534: [SPARK-15789][SQL] Allow reserved keywords in mos...

2016-06-07 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13534#discussion_r66161676 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -594,16 +594,13 @@ qualifiedName : identifier ('.'

[GitHub] spark pull request #13534: [SPARK-15789][SQL] Allow reserved keywords in mos...

2016-06-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13534#discussion_r66160129 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -594,16 +594,13 @@ qualifiedName : identifier ('.' i

[GitHub] spark pull request #13534: [SPARK-15789][SQL] Allow reserved keywords in mos...

2016-06-07 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13534#discussion_r66067691 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -594,16 +594,13 @@ qualifiedName : identifier ('.'

[GitHub] spark pull request #13534: [SPARK-15789][SQL] Allow reserved keywords in mos...

2016-06-06 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13534#discussion_r66016041 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -594,16 +594,13 @@ qualifiedName : identifier ('.' i

[GitHub] spark pull request #13534: [SPARK-15789][SQL] Allow reserved keywords in mos...

2016-06-06 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13534#discussion_r65975425 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -453,8 +453,8 @@ expression ; booleanExp

[GitHub] spark pull request #13534: [SPARK-15789][SQL] Allow reserved keywords in mos...

2016-06-06 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13534#discussion_r65975203 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -106,9 +106,9 @@ statement | SHOW FUNCTIONS (LIKE?

[GitHub] spark pull request #13534: [SPARK-15789][SQL] Allow reserved keywords in mos...

2016-06-06 Thread hvanhovell
GitHub user hvanhovell opened a pull request: https://github.com/apache/spark/pull/13534 [SPARK-15789][SQL] Allow reserved keywords in most places ## What changes were proposed in this pull request? The parser currently does not allow the use of some SQL keywords as table or fie