GitHub user bomeng opened a pull request:
https://github.com/apache/spark/pull/13695
[SPARK-15978] [SQL] remove unnecessary format
## What changes were proposed in this pull request?
I've found some minor issues in "show tables" command:
1. In the `SessionCatalog.scala`, `listTables(db: String)` method will call
`listTables(formatDatabaseName(db), "*")` to list all the tables for certain
db, but in the method `listTables(db: String, pattern: String)`, this db name
is formatted once more. So I think we should remove
`formatDatabaseName()` in the caller.
2. I suggest to add sort to listTables(db: String) in
InMemoryCatalog.scala, just like listDatabases().
## How was this patch tested?
The existing test cases should cover it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bomeng/spark SPARK-15978
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/13695.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13695
----
commit 2bbc919105e20a9c766f156e80fad18052395215
Author: bomeng <bm...@us.ibm.com>
Date: 2016-06-15T23:04:06Z
remove unnecessary format
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
