Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13894
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13894#discussion_r71392299
--- Diff: python/pyspark/ml/tuning.py ---
@@ -264,10 +264,10 @@ def copy(self, extra=None):
class CrossValidatorModel(Model, ValidatorParams):
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/13894#discussion_r70367155
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -56,7 +56,10 @@ private[ml] trait CrossValidatorParams extends
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/13894#discussion_r69892610
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -56,7 +56,10 @@ private[ml] trait CrossValidatorParams extends
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13894#discussion_r69809083
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -191,7 +194,8 @@ object CrossValidator extends
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13894#discussion_r69808182
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -56,7 +56,10 @@ private[ml] trait CrossValidatorParams extends
Github user krishnakalyan3 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13894#discussion_r69567260
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -57,7 +57,7 @@ private[ml] trait CrossValidatorParams extends
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/13894#discussion_r69524371
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -56,7 +56,10 @@ private[ml] trait CrossValidatorParams extends
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/13894#discussion_r69281183
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -56,7 +56,10 @@ private[ml] trait CrossValidatorParams extends
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/13894#discussion_r69133294
--- Diff: python/pyspark/ml/tuning.py ---
@@ -266,7 +269,7 @@ class CrossValidatorModel(Model, ValidatorParams):
"""
.. note:: Experimental
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/13894#discussion_r69133212
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -56,7 +56,10 @@ private[ml] trait CrossValidatorParams extends
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/13894#discussion_r69132912
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -191,7 +194,7 @@ object CrossValidator extends
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/13894#discussion_r69132570
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -56,7 +56,10 @@ private[ml] trait CrossValidatorParams extends
Github user krishnakalyan3 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13894#discussion_r69103201
--- Diff: python/pyspark/ml/tuning.py ---
@@ -266,7 +269,7 @@ class CrossValidatorModel(Model, ValidatorParams):
"""
.. note::
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13894#discussion_r69089084
--- Diff: python/pyspark/ml/tuning.py ---
@@ -266,8 +269,8 @@ class CrossValidatorModel(Model, ValidatorParams):
"""
.. note:: Experimental
Github user krishnakalyan3 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13894#discussion_r69086192
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -194,8 +194,7 @@ object CrossValidator extends
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13894#discussion_r68857452
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -191,7 +194,8 @@ object CrossValidator extends
GitHub user krishnakalyan3 opened a pull request:
https://github.com/apache/spark/pull/13894
[SPARK-15254][DOC] Improve ML pipeline Cross Validation Scaladoc & PyDoc
## What changes were proposed in this pull request?
Updated ML pipeline Cross Validation Scaladoc & PyDoc.
18 matches
Mail list logo