Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13919
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/13919#discussion_r69081332
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -351,11 +352,23 @@ class JDBCSuite extends SparkFunSuite
url
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/13919#discussion_r69081338
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -154,6 +158,10 @@ object JdbcUtils extends Loggi
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/13919#discussion_r69081362
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala
---
@@ -390,7 +390,11 @@ private[sql] class JDBCRDD(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/13919#discussion_r69081296
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -351,11 +352,23 @@ class JDBCSuite extends SparkFunSuite
url
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13919#discussion_r69080040
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala
---
@@ -390,7 +390,11 @@ private[sql] class JDBCRDD(
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13919#discussion_r69079913
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -154,6 +158,10 @@ object JdbcUtils extends Logging {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13919#discussion_r69079853
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -351,11 +352,23 @@ class JDBCSuite extends SparkFunSuite
urlWith
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13919#discussion_r69079897
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -351,11 +352,23 @@ class JDBCSuite extends SparkFunSuite
urlWith
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/13919#discussion_r69030861
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala
---
@@ -390,7 +390,9 @@ private[sql] class JDBCRDD(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/13919#discussion_r69030810
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCWriteSuite.scala ---
@@ -96,6 +98,30 @@ class JDBCWriteSuite extends SharedSQLContext with
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13919#discussion_r69030431
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCWriteSuite.scala ---
@@ -96,6 +98,30 @@ class JDBCWriteSuite extends SharedSQLContext with
Befo
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13919#discussion_r69030522
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala
---
@@ -390,7 +390,9 @@ private[sql] class JDBCRDD(
va
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/13919#discussion_r69029680
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala
---
@@ -390,7 +390,9 @@ private[sql] class JDBCRDD(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/13919#discussion_r69029404
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCWriteSuite.scala ---
@@ -96,6 +98,30 @@ class JDBCWriteSuite extends SharedSQLContext with
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/13919#discussion_r68673016
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCWriteSuite.scala ---
@@ -96,6 +98,30 @@ class JDBCWriteSuite extends SharedSQLContext with
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/13919#discussion_r68673001
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala
---
@@ -390,7 +390,9 @@ private[sql] class JDBCRDD(
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13919#discussion_r68672678
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCWriteSuite.scala ---
@@ -96,6 +98,30 @@ class JDBCWriteSuite extends SharedSQLContext with
Befo
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13919#discussion_r68672636
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala
---
@@ -390,7 +390,9 @@ private[sql] class JDBCRDD(
va
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/13919
[SPARK-16222] [SQL] JDBC Sources - Handling illegal input values for
`fetchsize` and `batchsize`
What changes were proposed in this pull request?
For JDBC data sources, users can specif
20 matches
Mail list logo
