[GitHub] spark pull request #14065: [SPARK-14743][YARN] Add a configurable token mana...

2016-07-20 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/14065#discussion_r71481579 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/security/ExecutorDelegationTokenUpdater.scala --- @@ -107,6 +110,14 @@ private[spark] class Exe

[GitHub] spark pull request #14065: [SPARK-14743][YARN] Add a configurable token mana...

2016-07-20 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/14065#discussion_r71480635 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -390,8 +391,21 @@ private[spark] class Client( // Upload Spark and t

[GitHub] spark pull request #14065: [SPARK-14743][YARN] Add a configurable token mana...

2016-07-19 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/14065#discussion_r71364134 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/security/ServiceCredentialProvider.scala --- @@ -0,0 +1,55 @@ +/* + * Licensed to the A

[GitHub] spark pull request #14065: [SPARK-14743][YARN] Add a configurable token mana...

2016-07-19 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/14065#discussion_r71363930 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/security/ServiceCredentialProvider.scala --- @@ -0,0 +1,55 @@ +/* + * Licensed to the A

[GitHub] spark pull request #14065: [SPARK-14743][YARN] Add a configurable token mana...

2016-07-19 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/14065#discussion_r71363393 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/security/ServiceCredentialProvider.scala --- @@ -0,0 +1,55 @@ +/* + * Licensed to the A

[GitHub] spark pull request #14065: [SPARK-14743][YARN] Add a configurable token mana...

2016-07-19 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/14065#discussion_r71362442 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/security/ExecutorDelegationTokenUpdater.scala --- @@ -107,6 +110,14 @@ private[spark] class Exe

[GitHub] spark pull request #14065: [SPARK-14743][YARN] Add a configurable token mana...

2016-07-19 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/14065#discussion_r71358746 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/security/AMDelegationTokenRenewer.scala --- @@ -171,10 +174,10 @@ private[yarn] class AMDelegat

[GitHub] spark pull request #14065: [SPARK-14743][YARN] Add a configurable token mana...

2016-07-19 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/14065#discussion_r71358595 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/security/AMDelegationTokenRenewer.scala --- @@ -171,10 +174,10 @@ private[yarn] class AMDelegat

[GitHub] spark pull request #14065: [SPARK-14743][YARN] Add a configurable token mana...

2016-07-19 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/14065#discussion_r71357664 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/security/AMDelegationTokenRenewer.scala --- @@ -171,10 +174,10 @@ private[yarn] class AMDelegat

[GitHub] spark pull request #14065: [SPARK-14743][YARN] Add a configurable token mana...

2016-07-19 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/14065#discussion_r71354857 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/security/AMDelegationTokenRenewer.scala --- @@ -193,10 +196,17 @@ private[yarn] class AMDelegat

[GitHub] spark pull request #14065: [SPARK-14743][YARN] Add a configurable token mana...

2016-07-19 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/14065#discussion_r71348341 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -390,8 +391,21 @@ private[spark] class Client( // Upload Spark and t

[GitHub] spark pull request #14065: [SPARK-14743][YARN] Add a configurable token mana...

2016-07-19 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/14065#discussion_r71349021 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -400,8 +414,6 @@ private[spark] class Client( // same name but diffe

[GitHub] spark pull request #14065: [SPARK-14743][YARN] Add a configurable token mana...

2016-07-19 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/14065#discussion_r71347178 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/config.scala --- @@ -319,6 +319,16 @@ package object config { .stringConf .crea

[GitHub] spark pull request #14065: [SPARK-14743][YARN] Add a configurable token mana...

2016-07-19 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/14065#discussion_r71343103 --- Diff: docs/running-on-yarn.md --- @@ -461,15 +461,28 @@ To use a custom metrics.properties for the application master and executors, upd

[GitHub] spark pull request #14065: [SPARK-14743][YARN] Add a configurable token mana...

2016-07-18 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/14065#discussion_r71121047 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/security/ConfigurableCredentialManager.scala --- @@ -0,0 +1,158 @@ +/* + * Licensed to

[GitHub] spark pull request #14065: [SPARK-14743][YARN] Add a configurable token mana...

2016-07-18 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/14065#discussion_r7198 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/security/AMDelegationTokenRenewer.scala --- @@ -193,8 +200,14 @@ private[yarn] class AMDelegati

[GitHub] spark pull request #14065: [SPARK-14743][YARN] Add a configurable token mana...

2016-07-18 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/14065#discussion_r71107536 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/security/AMDelegationTokenRenewer.scala --- @@ -69,6 +71,9 @@ private[yarn] class AMDelegationT

[GitHub] spark pull request #14065: [SPARK-14743][YARN] Add a configurable token mana...

2016-07-17 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/14065#discussion_r71104553 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -390,8 +393,22 @@ private[spark] class Client( // Upload Spark and t

[GitHub] spark pull request #14065: [SPARK-14743][YARN] Add a configurable token mana...

2016-07-17 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/14065#discussion_r71102254 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/security/ConfigurableCredentialManager.scala --- @@ -0,0 +1,158 @@ +/* + * Licensed to

[GitHub] spark pull request #14065: [SPARK-14743][YARN] Add a configurable token mana...

2016-07-17 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/14065#discussion_r71102195 --- Diff: dev/.rat-excludes --- @@ -99,3 +99,4 @@ spark-deps-.* .*tsv org.apache.spark.scheduler.ExternalClusterManager .*\.sql +org.apac

[GitHub] spark pull request #14065: [SPARK-14743][YARN] Add a configurable token mana...

2016-07-15 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/14065#discussion_r71049066 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/security/ConfigurableCredentialManager.scala --- @@ -0,0 +1,158 @@ +/* + * Licensed to the

[GitHub] spark pull request #14065: [SPARK-14743][YARN] Add a configurable token mana...

2016-07-15 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/14065#discussion_r71048935 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/security/ConfigurableCredentialManager.scala --- @@ -0,0 +1,158 @@ +/* + * Licensed to the

[GitHub] spark pull request #14065: [SPARK-14743][YARN] Add a configurable token mana...

2016-07-15 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/14065#discussion_r71048959 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/security/ConfigurableCredentialManager.scala --- @@ -0,0 +1,158 @@ +/* + * Licensed to the

[GitHub] spark pull request #14065: [SPARK-14743][YARN] Add a configurable token mana...

2016-07-15 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/14065#discussion_r71048752 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/security/ConfigurableCredentialManager.scala --- @@ -0,0 +1,158 @@ +/* + * Licensed to the

[GitHub] spark pull request #14065: [SPARK-14743][YARN] Add a configurable token mana...

2016-07-15 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/14065#discussion_r71048595 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/security/ConfigurableCredentialManager.scala --- @@ -0,0 +1,158 @@ +/* + * Licensed to the

[GitHub] spark pull request #14065: [SPARK-14743][YARN] Add a configurable token mana...

2016-07-15 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/14065#discussion_r71048326 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/security/ConfigurableCredentialManager.scala --- @@ -0,0 +1,158 @@ +/* + * Licensed to the

[GitHub] spark pull request #14065: [SPARK-14743][YARN] Add a configurable token mana...

2016-07-15 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/14065#discussion_r71048093 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/security/AMDelegationTokenRenewer.scala --- @@ -193,8 +200,14 @@ private[yarn] class AMDelegationT

[GitHub] spark pull request #14065: [SPARK-14743][YARN] Add a configurable token mana...

2016-07-15 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/14065#discussion_r71047970 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/security/AMDelegationTokenRenewer.scala --- @@ -193,8 +200,14 @@ private[yarn] class AMDelegationT

[GitHub] spark pull request #14065: [SPARK-14743][YARN] Add a configurable token mana...

2016-07-15 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/14065#discussion_r71047809 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/security/AMDelegationTokenRenewer.scala --- @@ -171,10 +175,13 @@ private[yarn] class AMDelegation

[GitHub] spark pull request #14065: [SPARK-14743][YARN] Add a configurable token mana...

2016-07-15 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/14065#discussion_r71047626 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/security/AMDelegationTokenRenewer.scala --- @@ -171,10 +175,13 @@ private[yarn] class AMDelegation

[GitHub] spark pull request #14065: [SPARK-14743][YARN] Add a configurable token mana...

2016-07-15 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/14065#discussion_r71047265 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/security/AMDelegationTokenRenewer.scala --- @@ -85,15 +90,14 @@ private[yarn] class AMDelegationTo

[GitHub] spark pull request #14065: [SPARK-14743][YARN] Add a configurable token mana...

2016-07-15 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/14065#discussion_r71046990 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/security/AMDelegationTokenRenewer.scala --- @@ -69,6 +71,9 @@ private[yarn] class AMDelegationToke

[GitHub] spark pull request #14065: [SPARK-14743][YARN] Add a configurable token mana...

2016-07-15 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/14065#discussion_r71046243 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -390,8 +393,22 @@ private[spark] class Client( // Upload Spark and the

[GitHub] spark pull request #14065: [SPARK-14743][YARN] Add a configurable token mana...

2016-07-15 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/14065#discussion_r71044195 --- Diff: dev/.rat-excludes --- @@ -99,3 +99,4 @@ spark-deps-.* .*tsv org.apache.spark.scheduler.ExternalClusterManager .*\.sql +org.apache.