[GitHub] spark pull request #14103: [SPARK-16436][SQL] checkEvaluation support NaN an...

2016-07-08 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/14103#discussion_r70029441 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala --- @@ -41,7 +41,12 @@ trait

[GitHub] spark pull request #14103: [SPARK-16436][SQL] checkEvaluation support NaN an...

2016-07-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14103#discussion_r70029140 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala --- @@ -41,7 +41,12 @@ trait

[GitHub] spark pull request #14103: [SPARK-16436][SQL] checkEvaluation support NaN an...

2016-07-07 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/14103#discussion_r70025935 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala --- @@ -63,6 +68,10 @@ trait

[GitHub] spark pull request #14103: [SPARK-16436][SQL] checkEvaluation support NaN an...

2016-07-07 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/14103#discussion_r70025887 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala --- @@ -41,7 +41,12 @@ trait

[GitHub] spark pull request #14103: [SPARK-16436][SQL] checkEvaluation support NaN an...

2016-07-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14103#discussion_r70024346 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala --- @@ -63,6 +68,10 @@ trait

[GitHub] spark pull request #14103: [SPARK-16436][SQL] checkEvaluation support NaN an...

2016-07-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14103#discussion_r70024354 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala --- @@ -41,7 +41,12 @@ trait

[GitHub] spark pull request #14103: [SPARK-16436][SQL] checkEvaluation support NaN an...

2016-07-07 Thread petermaxlee
GitHub user petermaxlee opened a pull request: https://github.com/apache/spark/pull/14103 [SPARK-16436][SQL] checkEvaluation support NaN and RuntimeReplaceable ## What changes were proposed in this pull request? This small patch modifies ExpressionEvalHelper. checkEvaluation to