Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14151
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user ScrapCodes commented on a diff in the pull request:
https://github.com/apache/spark/pull/14151#discussion_r155706338
--- Diff: python/pyspark/sql/readwriter.py ---
@@ -313,11 +313,16 @@ def text(self, paths):
Each line in the text file is a new row in the
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/14151#discussion_r155527201
--- Diff: python/pyspark/sql/readwriter.py ---
@@ -313,11 +313,16 @@ def text(self, paths):
Each line in the text file is a new row in the
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/14151#discussion_r155143739
--- Diff: python/pyspark/sql/readwriter.py ---
@@ -313,11 +313,13 @@ def text(self, paths):
Each line in the text file is a new row in the
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/14151#discussion_r15514
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/text/TextFileFormat.scala
---
@@ -97,14 +109,26 @@ class TextFileFormat
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/14151#discussion_r155139949
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/text/TextSuite.scala
---
@@ -39,6 +39,54 @@ class TextSuite extends QueryTest
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14151#discussion_r137601363
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/text/TextFileFormat.scala
---
@@ -101,10 +111,24 @@ class TextFileFormat
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14151#discussion_r137601163
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/text/TextFileFormat.scala
---
@@ -101,10 +111,24 @@ class TextFileFormat
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14151#discussion_r137601004
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/text/TextFileFormat.scala
---
@@ -99,8 +100,22 @@ class TextFileFormat
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14151#discussion_r137600781
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/text/TextFileFormat.scala
---
@@ -53,6 +57,12 @@ class TextFileFormat
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14151#discussion_r137595908
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/text/TextFileFormat.scala
---
@@ -101,10 +111,24 @@ class TextFileFormat
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14151#discussion_r137595716
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/text/TextSuite.scala
---
@@ -185,8 +233,7 @@ class TextSuite extends
Github user ScrapCodes commented on a diff in the pull request:
https://github.com/apache/spark/pull/14151#discussion_r131100257
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/HadoopFileWholeTextReader.scala
---
@@ -0,0 +1,57 @@
+/*
+ *
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14151#discussion_r130859352
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/text/TextSuite.scala
---
@@ -185,11 +231,11 @@ class TextSuite extends
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14151#discussion_r130859483
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/text/TextSuite.scala
---
@@ -39,6 +39,52 @@ class TextSuite extends
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14151#discussion_r130859601
--- Diff: python/pyspark/sql/readwriter.py ---
@@ -309,11 +309,13 @@ def text(self, paths):
Each line in the text file is a new row in the
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14151#discussion_r130858731
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/text/TextFileFormat.scala
---
@@ -101,10 +105,24 @@ class TextFileFormat
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/14151#discussion_r130267182
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/HadoopFileWholeTextReader.scala
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/14151#discussion_r130265982
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/HadoopFileWholeTextReader.scala
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed
Github user ScrapCodes commented on a diff in the pull request:
https://github.com/apache/spark/pull/14151#discussion_r81292587
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/text/TextFileFormat.scala
---
@@ -99,8 +100,22 @@ class TextFileFormat
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/14151#discussion_r81289022
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/text/TextFileFormat.scala
---
@@ -99,8 +100,22 @@ class TextFileFormat
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14151#discussion_r77118505
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/text/TextFileFormat.scala
---
@@ -99,8 +100,22 @@ class TextFileFormat
Github user ScrapCodes commented on a diff in the pull request:
https://github.com/apache/spark/pull/14151#discussion_r74903349
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -533,6 +533,12 @@ object SQLConf {
Github user ScrapCodes commented on a diff in the pull request:
https://github.com/apache/spark/pull/14151#discussion_r74902549
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/text/TextSuite.scala
---
@@ -39,6 +39,11 @@ class TextSuite extends
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14151#discussion_r74831276
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -533,6 +533,12 @@ object SQLConf {
Github user frreiss commented on a diff in the pull request:
https://github.com/apache/spark/pull/14151#discussion_r74805700
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/text/TextSuite.scala
---
@@ -39,6 +39,11 @@ class TextSuite extends QueryTest
Github user frreiss commented on a diff in the pull request:
https://github.com/apache/spark/pull/14151#discussion_r74804217
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -533,6 +533,12 @@ object SQLConf {
Github user ScrapCodes commented on a diff in the pull request:
https://github.com/apache/spark/pull/14151#discussion_r70564698
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/HadoopFileWholeTextReader.scala
---
@@ -0,0 +1,53 @@
+/*
+ *
Github user ScrapCodes commented on a diff in the pull request:
https://github.com/apache/spark/pull/14151#discussion_r70564514
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/HadoopFileWholeTextReader.scala
---
@@ -0,0 +1,53 @@
+/*
+ *
29 matches
Mail list logo