Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14176
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14176#discussion_r76341601
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -459,52 +475,91 @@ case class HashAggregateExec(
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14176#discussion_r76340251
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -518,15 +573,30 @@ case class HashAggregateExec(
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14176#discussion_r76340181
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -518,15 +573,30 @@ case class HashAggregateExec(
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14176#discussion_r76339927
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -459,52 +475,91 @@ case class HashAggregateExec(
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14176#discussion_r76339716
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -459,52 +475,91 @@ case class HashAggregateExec(
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14176#discussion_r76338880
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -459,52 +475,91 @@ case class HashAggregateExec(
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14176#discussion_r76338652
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -279,9 +280,14 @@ case class HashAggregateExec(
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14176#discussion_r76338535
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -279,9 +280,14 @@ case class HashAggregateExec(
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/14176#discussion_r73747170
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -499,14 +499,16 @@ object SQLConf {
.intConf
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/14176#discussion_r73747068
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/AggregateHashMapSuite.scala ---
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/14176#discussion_r73743987
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/AggregateHashMapSuite.scala ---
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/14176#discussion_r73070005
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -279,9 +280,15 @@ case class
Github user ooq commented on a diff in the pull request:
https://github.com/apache/spark/pull/14176#discussion_r73050331
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -279,9 +280,15 @@ case class HashAggregateExec(
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/14176#discussion_r73039793
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -499,14 +499,16 @@ object SQLConf {
.intConf
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/14176#discussion_r73039235
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -499,14 +499,16 @@ object SQLConf {
.intConf
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/14176#discussion_r73038918
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/RowBasedHashMapGenerator.scala
---
@@ -141,8 +141,16 @@ class
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/14176#discussion_r73038709
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -660,36 +778,74 @@ case class
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/14176#discussion_r73037506
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -459,52 +476,115 @@ case class
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/14176#discussion_r73036933
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -279,9 +280,15 @@ case class
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/14176#discussion_r73036686
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/FixedLengthRowBasedKeyValueBatch.java
---
@@ -165,10 +165,16 @@
GitHub user ooq opened a pull request:
https://github.com/apache/spark/pull/14176
[SPARK-16525][SQL] Enable Row Based HashMap in HashAggregateExec
## What changes were proposed in this pull request?
This PR is the second step for the following feature:
For hash
22 matches
Mail list logo
