[GitHub] spark pull request #14376: [SPARK-16749][SQL] Simplify processing logic in L...

2016-08-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14376 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #14376: [SPARK-16749][SQL] Simplify processing logic in L...

2016-08-08 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14376#discussion_r73959574 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WindowExec.scala --- @@ -565,7 +566,7 @@ private[execution] abstract class

[GitHub] spark pull request #14376: [SPARK-16749][SQL] Simplify processing logic in L...

2016-08-08 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14376#discussion_r73917166 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WindowExec.scala --- @@ -565,7 +566,7 @@ private[execution] abstract class

[GitHub] spark pull request #14376: [SPARK-16749][SQL] Simplify processing logic in L...

2016-07-27 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14376#discussion_r72458927 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WindowExec.scala --- @@ -209,7 +209,7 @@ case class WindowExec( new

[GitHub] spark pull request #14376: [SPARK-16749][SQL] Simplify processing logic in L...

2016-07-27 Thread hvanhovell
GitHub user hvanhovell opened a pull request: https://github.com/apache/spark/pull/14376 [SPARK-16749][SQL] Simplify processing logic in LEAD/LAG processing. ## What changes were proposed in this pull request? The logic for LEAD/LAG processing is more complex that it needs to