[GitHub] spark pull request #14400: [Spark-16791] [SQL] cast struct with timestamp fi...

2016-08-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14400 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #14400: [Spark-16791] [SQL] cast struct with timestamp fi...

2016-07-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14400#discussion_r72897142 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala --- @@ -727,6 +727,16 @@ class CastSuite extends SparkFunS

[GitHub] spark pull request #14400: [Spark-16791] [SQL] cast struct with timestamp fi...

2016-07-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14400#discussion_r72889243 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala --- @@ -727,6 +727,16 @@ class CastSuite extends SparkFunS

[GitHub] spark pull request #14400: [Spark-16791] [SQL] cast struct with timestamp fi...

2016-07-29 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14400#discussion_r72880474 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala --- @@ -727,6 +727,19 @@ class CastSuite extends SparkFunS

[GitHub] spark pull request #14400: [Spark-16791] [SQL] cast struct with timestamp fi...

2016-07-29 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/14400#discussion_r72770823 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala --- @@ -727,6 +727,19 @@ class CastSuite extends SparkFunSuit

[GitHub] spark pull request #14400: [Spark-16791] [SQL] cast struct with timestamp fi...

2016-07-29 Thread eyalfa
Github user eyalfa commented on a diff in the pull request: https://github.com/apache/spark/pull/14400#discussion_r72769633 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala --- @@ -727,6 +727,19 @@ class CastSuite extends SparkFunSuit

[GitHub] spark pull request #14400: [Spark-16791] [SQL] cast struct with timestamp fi...

2016-07-29 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/14400#discussion_r72764975 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala --- @@ -727,6 +727,19 @@ class CastSuite extends SparkFunSuit

[GitHub] spark pull request #14400: [Spark-16791] [SQL] cast struct with timestamp fi...

2016-07-29 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/14400#discussion_r72764850 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -416,7 +416,7 @@ case class Cast(child: Expression, dataTyp

[GitHub] spark pull request #14400: [Spark-16791] [SQL] cast struct with timestamp fi...

2016-07-29 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/14400#discussion_r72764866 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala --- @@ -727,6 +727,19 @@ class CastSuite extends SparkFunSuit

[GitHub] spark pull request #14400: [Spark-16791] [SQL] cast struct with timestamp fi...

2016-07-29 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/14400#discussion_r72764858 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala --- @@ -727,6 +727,19 @@ class CastSuite extends SparkFunSuit

[GitHub] spark pull request #14400: [Spark-16791] [SQL] cast struct with timestamp fi...

2016-07-29 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/14400#discussion_r72764872 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala --- @@ -727,6 +727,19 @@ class CastSuite extends SparkFunSuit

[GitHub] spark pull request #14400: [Spark-16791] [SQL] cast struct with timestamp fi...

2016-07-29 Thread eyalfa
GitHub user eyalfa opened a pull request: https://github.com/apache/spark/pull/14400 [Spark-16791] [SQL] cast struct with timestamp field fails ## What changes were proposed in this pull request? a failing test case + fix to SPARK-16791 (https://issues.apache.org/jira/browse/SPA