[GitHub] spark pull request #14434: [SPARK-16828][SQL] remove MaxOf and MinOf

2016-08-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14434 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #14434: [SPARK-16828][SQL] remove MaxOf and MinOf

2016-08-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14434#discussion_r73073652 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -662,10 +662,6 @@ object NullPropagation extends

[GitHub] spark pull request #14434: [SPARK-16828][SQL] remove MaxOf and MinOf

2016-08-01 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14434#discussion_r73023513 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -662,10 +662,6 @@ object NullPropagation extends

[GitHub] spark pull request #14434: [SPARK-16828][SQL] remove MaxOf and MinOf

2016-08-01 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/14434 [SPARK-16828][SQL] remove MaxOf and MinOf ## What changes were proposed in this pull request? These 2 expressions are not needed anymore after we have `Greatest` and `Least`. This PR