[GitHub] spark pull request #14470: [SPARK-16863][ML] ProbabilisticClassifier.fit che...

2016-08-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14470 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #14470: [SPARK-16863][ML] ProbabilisticClassifier.fit che...

2016-08-04 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14470#discussion_r73565125 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala --- @@ -84,6 +84,13 @@ class DecisionTreeClassifier

[GitHub] spark pull request #14470: [SPARK-16863][ML] ProbabilisticClassifier.fit che...

2016-08-03 Thread zhengruifeng
Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/14470#discussion_r73465384 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala --- @@ -84,6 +84,13 @@ class DecisionTreeClassifier

[GitHub] spark pull request #14470: [SPARK-16863][ML] ProbabilisticClassifier.fit che...

2016-08-03 Thread zhengruifeng
Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/14470#discussion_r73465400 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/NaiveBayes.scala --- @@ -101,6 +101,14 @@ class NaiveBayes @Since("1.5.0") (

[GitHub] spark pull request #14470: [SPARK-16863][ML] ProbabilisticClassifier.fit che...

2016-08-03 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14470#discussion_r73321403 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/NaiveBayes.scala --- @@ -101,6 +101,14 @@ class NaiveBayes @Since("1.5.0") (

[GitHub] spark pull request #14470: [SPARK-16863][ML] ProbabilisticClassifier.fit che...

2016-08-03 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14470#discussion_r73321286 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala --- @@ -84,6 +84,13 @@ class DecisionTreeClassifier

[GitHub] spark pull request #14470: [SPARK-16863][ML] ProbabilisticClassifier.fit che...

2016-08-02 Thread zhengruifeng
GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/14470 [SPARK-16863][ML] ProbabilisticClassifier.fit check threshoulds' length ## What changes were proposed in this pull request? Add threshoulds' length checking for Classifiers which