Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14555
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14555#discussion_r74397043
--- Diff:
mllib-local/src/test/scala/org/apache/spark/ml/linalg/VectorsSuite.scala ---
@@ -72,6 +72,12 @@ class VectorsSuite extends SparkMLFunSuite {
Github user zjffdu commented on a diff in the pull request:
https://github.com/apache/spark/pull/14555#discussion_r74396667
--- Diff:
mllib-local/src/test/scala/org/apache/spark/ml/linalg/VectorsSuite.scala ---
@@ -72,6 +72,12 @@ class VectorsSuite extends SparkMLFunSuite {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14555#discussion_r74395330
--- Diff:
mllib-local/src/test/scala/org/apache/spark/ml/linalg/VectorsSuite.scala ---
@@ -72,6 +72,12 @@ class VectorsSuite extends SparkMLFunSuite {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14555#discussion_r74208842
--- Diff: python/pyspark/ml/linalg/__init__.py ---
@@ -511,6 +519,12 @@ def __init__(self, size, *args):
"Indices %s and %s are
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14555#discussion_r74208436
--- Diff:
mllib-local/src/test/scala/org/apache/spark/ml/linalg/VectorsSuite.scala ---
@@ -72,6 +72,12 @@ class VectorsSuite extends SparkMLFunSuite {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14555#discussion_r74208355
--- Diff:
mllib-local/src/main/scala/org/apache/spark/ml/linalg/Vectors.scala ---
@@ -560,11 +554,26 @@ class SparseVector @Since("2.0.0") (
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14555#discussion_r74208246
--- Diff:
mllib-local/src/main/scala/org/apache/spark/ml/linalg/Vectors.scala ---
@@ -560,11 +554,26 @@ class SparseVector @Since("2.0.0") (
Github user zjffdu commented on a diff in the pull request:
https://github.com/apache/spark/pull/14555#discussion_r74022257
--- Diff:
mllib-local/src/main/scala/org/apache/spark/ml/linalg/Vectors.scala ---
@@ -560,11 +554,25 @@ class SparseVector @Since("2.0.0") (
Github user zjffdu commented on a diff in the pull request:
https://github.com/apache/spark/pull/14555#discussion_r74021856
--- Diff:
mllib-local/src/main/scala/org/apache/spark/ml/linalg/Vectors.scala ---
@@ -560,11 +554,25 @@ class SparseVector @Since("2.0.0") (
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14555#discussion_r74021332
--- Diff:
mllib-local/src/main/scala/org/apache/spark/ml/linalg/Vectors.scala ---
@@ -560,11 +554,25 @@ class SparseVector @Since("2.0.0") (
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14555#discussion_r74021092
--- Diff:
mllib-local/src/main/scala/org/apache/spark/ml/linalg/Vectors.scala ---
@@ -560,11 +554,25 @@ class SparseVector @Since("2.0.0") (
Github user zjffdu commented on a diff in the pull request:
https://github.com/apache/spark/pull/14555#discussion_r74009150
--- Diff:
mllib-local/src/main/scala/org/apache/spark/ml/linalg/Vectors.scala ---
@@ -560,11 +554,25 @@ class SparseVector @Since("2.0.0") (
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14555#discussion_r74006226
--- Diff:
mllib-local/src/main/scala/org/apache/spark/ml/linalg/Vectors.scala ---
@@ -560,11 +554,25 @@ class SparseVector @Since("2.0.0") (
Github user zjffdu commented on a diff in the pull request:
https://github.com/apache/spark/pull/14555#discussion_r74006057
--- Diff:
mllib-local/src/main/scala/org/apache/spark/ml/linalg/Vectors.scala ---
@@ -560,11 +554,25 @@ class SparseVector @Since("2.0.0") (
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14555#discussion_r74005289
--- Diff:
mllib-local/src/main/scala/org/apache/spark/ml/linalg/Vectors.scala ---
@@ -560,11 +554,25 @@ class SparseVector @Since("2.0.0") (
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14555#discussion_r74005178
--- Diff:
mllib-local/src/main/scala/org/apache/spark/ml/linalg/Vectors.scala ---
@@ -560,11 +554,25 @@ class SparseVector @Since("2.0.0") (
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14555#discussion_r74005184
--- Diff:
mllib-local/src/main/scala/org/apache/spark/ml/linalg/Vectors.scala ---
@@ -560,11 +554,25 @@ class SparseVector @Since("2.0.0") (
GitHub user zjffdu opened a pull request:
https://github.com/apache/spark/pull/14555
[SPARK-16965][MLLIB][PYSPARK] Fix bound checking for SparseVector.
## What changes were proposed in this pull request?
1. In scala, add negative low bound checking and put all the low/upper
19 matches
Mail list logo
