[GitHub] spark pull request #14571: [SPARK-16983][SQL] Add `prettyName` for row_numbe...

2016-08-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14571 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #14571: [SPARK-16983][SQL] Add `prettyName` for row_numbe...

2016-08-24 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14571#discussion_r76096178 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala --- @@ -675,6 +675,7 @@ case class DenseRank(c

[GitHub] spark pull request #14571: [SPARK-16983][SQL] Add `prettyName` for row_numbe...

2016-08-24 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14571#discussion_r76086808 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala --- @@ -675,6 +675,7 @@ case class DenseRank(chil

[GitHub] spark pull request #14571: [SPARK-16983][SQL] Add `prettyName` for row_numbe...

2016-08-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14571#discussion_r74193132 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala --- @@ -675,6 +675,7 @@ case class DenseRank(c

[GitHub] spark pull request #14571: [SPARK-16983][SQL] Add `prettyName` for row_numbe...

2016-08-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14571#discussion_r74192984 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala --- @@ -675,6 +675,7 @@ case class DenseRank(c

[GitHub] spark pull request #14571: [SPARK-16983][SQL] Add `prettyName` for row_numbe...

2016-08-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14571#discussion_r74192723 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala --- @@ -675,6 +675,7 @@ case class DenseRank(children:

[GitHub] spark pull request #14571: [SPARK-16983][SQL] Add `prettyName` for row_numbe...

2016-08-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14571#discussion_r74184702 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala --- @@ -675,6 +675,7 @@ case class DenseRank(c

[GitHub] spark pull request #14571: [SPARK-16983][SQL] Add `prettyName` for row_numbe...

2016-08-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14571#discussion_r74184622 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala --- @@ -675,6 +675,7 @@ case class DenseRank(children:

[GitHub] spark pull request #14571: [SPARK-16983][SQL] Add `prettyName` for row_numbe...

2016-08-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14571#discussion_r74183323 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala --- @@ -478,6 +478,7 @@ object SizeBasedWindow

[GitHub] spark pull request #14571: [SPARK-16983][SQL] Add `prettyName` for row_numbe...

2016-08-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14571#discussion_r74183057 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala --- @@ -478,6 +478,7 @@ object SizeBasedWindowFunction

[GitHub] spark pull request #14571: [SPARK-16983][SQL] Add `prettyName` for row_numbe...

2016-08-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14571#discussion_r74183002 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala --- @@ -478,6 +478,7 @@ object SizeBasedWindow

[GitHub] spark pull request #14571: [SPARK-16983][SQL] Add `prettyName` for row_numbe...

2016-08-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14571#discussion_r74182897 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala --- @@ -478,6 +478,7 @@ object SizeBasedWindow

[GitHub] spark pull request #14571: [SPARK-16983][SQL] Add `prettyName` for row_numbe...

2016-08-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14571#discussion_r74182139 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala --- @@ -478,6 +478,7 @@ object SizeBasedWindowFunction

[GitHub] spark pull request #14571: [SPARK-16983][SQL] Add `prettyName` for row_numbe...

2016-08-09 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/14571 [SPARK-16983][SQL] Add `prettyName` for row_number, dense_rank, percent_rank, cume_dist ## What changes were proposed in this pull request? Currently, two-word window functions like