[GitHub] spark pull request #14616: [SPARK-16955][SQL] Fix analysis error when using ...

2016-08-12 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14616#discussion_r74555273 --- Diff: sql/core/src/test/resources/sql-tests/results/group-by-ordinal.sql.out --- @@ -95,7 +95,7 @@ select a, b from data group by -1 struct<> --

[GitHub] spark pull request #14616: [SPARK-16955][SQL] Fix analysis error when using ...

2016-08-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14616#discussion_r74556830 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -2223,3 +2223,29 @@ object TimeWindowing extends

[GitHub] spark pull request #14616: [SPARK-16955][SQL] Fix analysis error when using ...

2016-08-12 Thread clockfly
Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/14616#discussion_r74556035 --- Diff: sql/core/src/test/resources/sql-tests/results/group-by-ordinal.sql.out --- @@ -95,7 +95,7 @@ select a, b from data group by -1 struct<>

[GitHub] spark pull request #14616: [SPARK-16955][SQL] Fix analysis error when using ...

2016-08-12 Thread clockfly
Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/14616#discussion_r7466 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -2223,3 +2223,29 @@ object TimeWindowing extends

[GitHub] spark pull request #14616: [SPARK-16955][SQL] Fix analysis error when using ...

2016-08-12 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14616#discussion_r74555215 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -2223,3 +2223,29 @@ object TimeWindowing extends

[GitHub] spark pull request #14616: [SPARK-16955][SQL] Fix analysis error when using ...

2016-08-11 Thread clockfly
GitHub user clockfly opened a pull request: https://github.com/apache/spark/pull/14616 [SPARK-16955][SQL] Fix analysis error when using ordinal in ORDER BY or GROUP BY ## What changes were proposed in this pull request? This PR adds two unresolved expressions to represent