Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14753
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r76264528
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/TypedImperativeAggregateSuite.scala
---
@@ -0,0 +1,300 @@
+/*
+ * Licensed to the Apache
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r76263947
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,144 @@ abstract class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r76225656
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,144 @@ abstract class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r76189865
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/TypedImperativeAggregateSuite.scala
---
@@ -0,0 +1,300 @@
+/*
+ * Licensed to the Apache
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r76181435
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/TypedImperativeAggregateSuite.scala
---
@@ -0,0 +1,300 @@
+/*
+ * Licensed to the Apache
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r76177616
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/TypedImperativeAggregateSuite.scala
---
@@ -0,0 +1,300 @@
+/*
+ * Licensed to the Apache
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r76176167
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/TypedImperativeAggregateSuite.scala
---
@@ -0,0 +1,300 @@
+/*
+ * Licensed to the Apache
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r76175290
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggregationIterator.scala
---
@@ -234,7 +234,24 @@ abstract class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r76173845
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggregationIterator.scala
---
@@ -234,7 +234,24 @@ abstract class
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r76163999
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggregationIterator.scala
---
@@ -234,7 +234,20 @@ abstract class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r76161895
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/TypedImperativeAggregateSuite.scala
---
@@ -0,0 +1,261 @@
+/*
+ * Licensed to the Apache
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r76158137
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,175 @@ abstract class
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r76157178
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/TypedImperativeAggregateSuite.scala
---
@@ -0,0 +1,261 @@
+/*
+ * Licensed to the Apache
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r76156969
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/TypedImperativeAggregateSuite.scala
---
@@ -0,0 +1,261 @@
+/*
+ * Licensed to the Apache
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r76155973
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/TypedImperativeAggregateSuite.scala
---
@@ -0,0 +1,261 @@
+/*
+ * Licensed to the Apache
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r76154134
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggregationIterator.scala
---
@@ -234,7 +234,20 @@ abstract class
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r76154000
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,144 @@ abstract class
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r76152853
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,144 @@ abstract class
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r76152607
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,144 @@ abstract class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r76093898
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,144 @@ abstract class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r76056653
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,143 @@ abstract class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r76049580
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/TypedImperativeAggregateSuite.scala
---
@@ -0,0 +1,263 @@
+/*
+ * Licensed to the Apache
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r76034794
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,145 @@ abstract class
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r76034179
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,145 @@ abstract class
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r76034137
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/TypedImperativeAggregateSuite.scala
---
@@ -0,0 +1,229 @@
+/*
+ * Licensed to the Apache
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r76023369
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/TypedImperativeAggregateSuite.scala
---
@@ -0,0 +1,229 @@
+/*
+ * Licensed to the Apache
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r76023022
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/TypedImperativeAggregateSuite.scala
---
@@ -0,0 +1,229 @@
+/*
+ * Licensed to the Apache
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r76022712
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,145 @@ abstract class
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r76001378
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/TypedImperativeAggregateSuite.scala
---
@@ -0,0 +1,234 @@
+/*
+ * Licensed to the Apache
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r76000196
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/TypedImperativeAggregateSuite.scala
---
@@ -0,0 +1,234 @@
+/*
+ * Licensed to the Apache
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r76000216
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/TypedImperativeAggregateSuite.scala
---
@@ -0,0 +1,234 @@
+/*
+ * Licensed to the Apache
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r75999634
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,153 @@ abstract class
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r75999559
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,146 @@ abstract class
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r75997361
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/SortBasedAggregationIterator.scala
---
@@ -131,6 +150,11 @@ class
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r75997312
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/SortBasedAggregationIterator.scala
---
@@ -131,6 +150,11 @@ class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r75994611
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,153 @@ abstract class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r75994597
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,153 @@ abstract class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r75994519
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/SortBasedAggregationIterator.scala
---
@@ -90,6 +91,24 @@ class
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r75994509
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,175 @@ abstract class
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r75969912
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/TypedImperativeAggregateSuite.scala
---
@@ -0,0 +1,235 @@
+/*
+ * Licensed to the Apache
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r75968351
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,146 @@ abstract class
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r75968233
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,175 @@ abstract class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r75860653
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/TypedImperativeAggregateSuite.scala
---
@@ -0,0 +1,235 @@
+/*
+ * Licensed to the Apache
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r75858852
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,146 @@ abstract class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r75858434
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,175 @@ abstract class
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r75798274
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,175 @@ abstract class
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r75797813
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,146 @@ abstract class
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r75797539
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,175 @@ abstract class
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r75797479
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,175 @@ abstract class
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r75797504
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,175 @@ abstract class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r75793140
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,175 @@ abstract class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r75793025
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,175 @@ abstract class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r75792744
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,175 @@ abstract class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r75792506
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,175 @@ abstract class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r75792480
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,175 @@ abstract class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r75792451
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,175 @@ abstract class
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r75784293
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,148 @@ abstract class
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r75776471
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,148 @@ abstract class
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14753#discussion_r75776503
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,148 @@ abstract class
GitHub user clockfly opened a pull request:
https://github.com/apache/spark/pull/14753
[SPARK-17187][SQL] Supports using arbitrary Java object as internal
aggregation buffer object
## What changes were proposed in this pull request?
This PR introduces an abstract class
61 matches
Mail list logo
