[GitHub] spark pull request #14809: [SPARK-17238][SQL] simplify the logic for convert...

2016-09-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14809 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #14809: [SPARK-17238][SQL] simplify the logic for convert...

2016-09-06 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14809#discussion_r77578688 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -272,17 +282,11 @@ private[spark] class

[GitHub] spark pull request #14809: [SPARK-17238][SQL] simplify the logic for convert...

2016-09-05 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14809#discussion_r77560966 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -241,10 +241,21 @@ private[spark] class

[GitHub] spark pull request #14809: [SPARK-17238][SQL] simplify the logic for convert...

2016-09-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14809#discussion_r77295778 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -241,10 +241,21 @@ private[spark] class

[GitHub] spark pull request #14809: [SPARK-17238][SQL] simplify the logic for convert...

2016-09-01 Thread clockfly
Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/14809#discussion_r77294000 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -272,17 +282,11 @@ private[spark] class

[GitHub] spark pull request #14809: [SPARK-17238][SQL] simplify the logic for convert...

2016-09-01 Thread clockfly
Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/14809#discussion_r77293800 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -241,10 +241,21 @@ private[spark] class

[GitHub] spark pull request #14809: [SPARK-17238][SQL] simplify the logic for convert...

2016-08-25 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/14809 [SPARK-17238][SQL] simplify the logic for converting data source table into hive compatible format ## What changes were proposed in this pull request? Previously we have 2 conditions to