[GitHub] spark pull request #14921: [SPARK-17361][SQL] createExternalTable should fai...

2016-09-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14921#discussion_r77292635 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -314,12 +314,8 @@ case class DataSource( /**

[GitHub] spark pull request #14921: [SPARK-17361][SQL] createExternalTable should fai...

2016-09-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14921#discussion_r77292575 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -314,12 +314,8 @@ case class DataSource( /**

[GitHub] spark pull request #14921: [SPARK-17361][SQL] createExternalTable should fai...

2016-09-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14921#discussion_r77292542 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -314,12 +314,8 @@ case class DataSource( /**

[GitHub] spark pull request #14921: [SPARK-17361][SQL] createExternalTable should fai...

2016-09-01 Thread clockfly
Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/14921#discussion_r77292448 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -314,12 +314,8 @@ case class DataSource( /**

[GitHub] spark pull request #14921: [SPARK-17361][SQL] createExternalTable should fai...

2016-09-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14921#discussion_r77292357 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -314,12 +314,8 @@ case class DataSource( /**

[GitHub] spark pull request #14921: [SPARK-17361][SQL] createExternalTable should fai...

2016-09-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14921#discussion_r77291908 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -314,12 +314,8 @@ case class DataSource( /**

[GitHub] spark pull request #14921: [SPARK-17361][SQL] createExternalTable should fai...

2016-09-01 Thread clockfly
Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/14921#discussion_r77290803 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -314,12 +314,8 @@ case class DataSource( /**

[GitHub] spark pull request #14921: [SPARK-17361][SQL] createExternalTable should fai...

2016-09-01 Thread clockfly
Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/14921#discussion_r77290773 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -314,12 +314,8 @@ case class DataSource( /**

[GitHub] spark pull request #14921: [SPARK-17361][SQL] createExternalTable should fai...

2016-09-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14921#discussion_r77191588 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ListingFileCatalog.scala --- @@ -37,16 +34,12 @@ import

[GitHub] spark pull request #14921: [SPARK-17361][SQL] createExternalTable should fai...

2016-09-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14921#discussion_r77191436 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -314,12 +314,8 @@ case class DataSource( /**

[GitHub] spark pull request #14921: [SPARK-17361][SQL] createExternalTable should fai...

2016-09-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14921#discussion_r77191147 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -155,9 +155,9 @@ case class CatalogTable(

[GitHub] spark pull request #14921: [SPARK-17361][SQL] createExternalTable should fai...

2016-09-01 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/14921 [SPARK-17361][SQL] createExternalTable should fail if path is not given for file-based data source ## What changes were proposed in this pull request? Using the public `Catalog` API,