Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/15044
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15044#discussion_r86695190
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/PrimitiveArrayBenchmark.scala
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15044#discussion_r86695178
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/RowEncoderSuite.scala
---
@@ -191,6 +191,32 @@ class RowEncoderSuite extends Spar
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15044#discussion_r86695177
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
---
@@ -987,6 +987,24 @@ class DatasetSuite extends QueryTest with
SharedSQLContext
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15044#discussion_r86665607
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/PrimitiveArrayBenchmark.scala
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15044#discussion_r86665500
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/PrimitiveArrayBenchmark.scala
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15044#discussion_r86665433
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/RowEncoderSuite.scala
---
@@ -191,6 +191,32 @@ class RowEncoderSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15044#discussion_r86665398
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/RowEncoder.scala
---
@@ -119,18 +119,20 @@ object RowEncoder {
"
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15044#discussion_r86665392
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/RowEncoder.scala
---
@@ -119,18 +119,20 @@ object RowEncoder {
"
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15044#discussion_r86659238
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystTypeConverters.scala
---
@@ -158,6 +158,20 @@ object CatalystTypeConverters {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15044#discussion_r86525424
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -441,6 +441,28 @@ object ScalaReflection extends ScalaReflect
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15044#discussion_r86524552
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -993,7 +993,7 @@ case class ValidateExternalType(
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15044#discussion_r86524472
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/RowEncoder.scala
---
@@ -193,7 +211,8 @@ object RowEncoder {
// as java.
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15044#discussion_r86524358
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/RowEncoder.scala
---
@@ -119,18 +119,36 @@ object RowEncoder {
"from
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15044#discussion_r86524329
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/RowEncoder.scala
---
@@ -119,18 +119,36 @@ object RowEncoder {
"from
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15044#discussion_r86524255
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystTypeConverters.scala
---
@@ -158,6 +158,20 @@ object CatalystTypeConverters {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15044#discussion_r86489106
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/RowEncoder.scala
---
@@ -119,18 +119,36 @@ object RowEncoder {
"
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15044#discussion_r86488905
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -441,6 +441,28 @@ object ScalaReflection extends ScalaRef
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15044#discussion_r86358423
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/RowEncoder.scala
---
@@ -119,18 +119,36 @@ object RowEncoder {
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15044#discussion_r86358654
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -993,7 +993,7 @@ case class ValidateExternal
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15044#discussion_r86358543
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/RowEncoder.scala
---
@@ -193,7 +211,8 @@ object RowEncoder {
// as
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15044#discussion_r83380369
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/CatalystTypeConvertersSuite.scala
---
@@ -61,4 +63,39 @@ class CatalystTypeConvertersSuite
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15044#discussion_r83300104
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/CatalystTypeConvertersSuite.scala
---
@@ -61,4 +63,39 @@ class CatalystTypeConverters
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15044#discussion_r82244393
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -441,6 +441,28 @@ object ScalaReflection extends ScalaRe
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15044#discussion_r82058100
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -441,6 +441,28 @@ object ScalaReflection extends ScalaRe
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15044#discussion_r82056906
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/PrimitiveArrayBenchmark.scala
---
@@ -0,0 +1,72 @@
+/*
+ * Licensed to
26 matches
Mail list logo
