[GitHub] spark pull request #15239: [SPARK-17665][SPARKR][WIP] Support options/mode a...

2016-09-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15239#discussion_r80606823 --- Diff: R/pkg/R/SQLContext.R --- @@ -835,7 +843,7 @@ loadDF <- function(x, ...) { #' @note createExternalTable since 1.4.0

[GitHub] spark pull request #15239: [SPARK-17665][SPARKR][WIP] Support options/mode a...

2016-09-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15239#discussion_r80606767 --- Diff: R/pkg/R/utils.R --- @@ -334,6 +334,27 @@ varargsToEnv <- function(...) { env } +# Utility function to capture the varargs

[GitHub] spark pull request #15239: [SPARK-17665][SPARKR][WIP] Support options/mode a...

2016-09-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15239#discussion_r80605768 --- Diff: R/pkg/R/DataFrame.R --- @@ -743,8 +743,12 @@ setMethod("toJSON", #' @note write.json since 1.6.0 setMethod("write.json",

[GitHub] spark pull request #15239: [SPARK-17665][SPARKR][WIP] Support options/mode a...

2016-09-26 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/15239#discussion_r80541497 --- Diff: R/pkg/R/SQLContext.R --- @@ -835,7 +843,7 @@ loadDF <- function(x, ...) { #' @note createExternalTable since 1.4.0

[GitHub] spark pull request #15239: [SPARK-17665][SPARKR][WIP] Support options/mode a...

2016-09-26 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/15239#discussion_r80540973 --- Diff: R/pkg/R/utils.R --- @@ -334,6 +334,27 @@ varargsToEnv <- function(...) { env } +# Utility function to capture the varargs

[GitHub] spark pull request #15239: [SPARK-17665][SPARKR][WIP] Support options/mode a...

2016-09-26 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/15239#discussion_r80540376 --- Diff: R/pkg/R/DataFrame.R --- @@ -743,8 +743,12 @@ setMethod("toJSON", #' @note write.json since 1.6.0 setMethod("write.json",