Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15277#discussion_r81119230
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala ---
@@ -57,22 +69,21 @@ class ChiSqSelectorModel @Since("1.3.0") (
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15277#discussion_r81117619
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala ---
@@ -57,22 +69,21 @@ class ChiSqSelectorModel @Since("1.3.0") (
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/15277
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15277#discussion_r81116099
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala ---
@@ -57,22 +69,21 @@ class ChiSqSelectorModel @Since("1.3.0") (
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15277#discussion_r81113901
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala ---
@@ -57,22 +69,21 @@ class ChiSqSelectorModel @Since("1.3.0") (
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15277#discussion_r8257
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala ---
@@ -57,22 +69,21 @@ class ChiSqSelectorModel @Since("1.3.0") (
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15277#discussion_r81102204
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala ---
@@ -57,22 +69,21 @@ class ChiSqSelectorModel @Since("1.3.0") (
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15277#discussion_r81102445
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala ---
@@ -220,18 +231,22 @@ class ChiSqSelector @Since("2.1.0") () extends
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15277#discussion_r81101636
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala ---
@@ -57,22 +69,21 @@ class ChiSqSelectorModel @Since("1.3.0") (
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15277#discussion_r81100804
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala ---
@@ -57,22 +69,21 @@ class ChiSqSelectorModel @Since("1.3.0") (
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15277#discussion_r81100441
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala ---
@@ -57,22 +69,21 @@ class ChiSqSelectorModel @Since("1.3.0") (
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15277#discussion_r81085184
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala ---
@@ -57,22 +69,21 @@ class ChiSqSelectorModel @Since("1.3.0") (
Github user mpjlu commented on a diff in the pull request:
https://github.com/apache/spark/pull/15277#discussion_r80961052
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala ---
@@ -57,22 +69,21 @@ class ChiSqSelectorModel @Since("1.3.0") (
*
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15277#discussion_r80915095
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala ---
@@ -57,22 +69,21 @@ class ChiSqSelectorModel @Since("1.3.0") (
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15277#discussion_r80863287
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala ---
@@ -57,22 +69,21 @@ class ChiSqSelectorModel @Since("1.3.0") (
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15277#discussion_r80863514
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala ---
@@ -220,18 +231,22 @@ class ChiSqSelector @Since("2.1.0") ()
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/15277
[SPARK-17704][ML][MLlib] ChiSqSelector performance improvement.
## What changes were proposed in this pull request?
Several performance improvement for ```ChiSqSelector```:
1, Keep
17 matches
Mail list logo
