[GitHub] spark pull request #15618: [SPARK-14914][CORE] Fix Resource not closed after...

2016-11-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15618 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #15618: [SPARK-14914][CORE] Fix Resource not closed after...

2016-11-07 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15618#discussion_r86767759 --- Diff: streaming/src/test/scala/org/apache/spark/streaming/MapWithStateSuite.scala --- @@ -38,19 +38,16 @@ class MapWithStateSuite extends

[GitHub] spark pull request #15618: [SPARK-14914][CORE] Fix Resource not closed after...

2016-11-07 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15618#discussion_r86767539 --- Diff: streaming/src/test/scala/org/apache/spark/streaming/MapWithStateSuite.scala --- @@ -38,19 +38,16 @@ class MapWithStateSuite extends

[GitHub] spark pull request #15618: [SPARK-14914][CORE] Fix Resource not closed after...

2016-11-06 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15618#discussion_r86687384 --- Diff: streaming/src/test/scala/org/apache/spark/streaming/MapWithStateSuite.scala --- @@ -38,19 +38,16 @@ class MapWithStateSuite extends SparkFunSuite

[GitHub] spark pull request #15618: [SPARK-14914][CORE] Fix Resource not closed after...

2016-11-01 Thread HyukjinKwon
Github user HyukjinKwon closed the pull request at: https://github.com/apache/spark/pull/15618 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request #15618: [SPARK-14914][CORE] Fix Resource not closed after...

2016-11-01 Thread HyukjinKwon
GitHub user HyukjinKwon reopened a pull request: https://github.com/apache/spark/pull/15618 [SPARK-14914][CORE] Fix Resource not closed after using, mostly for unit tests ## What changes were proposed in this pull request? Close `FileStreams`, `ZipFiles` etc to release the

[GitHub] spark pull request #15618: [SPARK-14914][CORE] Fix Resource not closed after...

2016-11-01 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15618#discussion_r85934066 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/scheduler/ReceiverTracker.scala --- @@ -154,6 +147,17 @@ class ReceiverTracker(ssc:

[GitHub] spark pull request #15618: [SPARK-14914][CORE] Fix Resource not closed after...

2016-10-30 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15618#discussion_r85663718 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/scheduler/ReceiverTracker.scala --- @@ -202,18 +206,21 @@ class ReceiverTracker(ssc:

[GitHub] spark pull request #15618: [SPARK-14914][CORE] Fix Resource not closed after...

2016-10-30 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15618#discussion_r85663898 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/scheduler/ReceiverTracker.scala --- @@ -154,6 +147,17 @@ class ReceiverTracker(ssc:

[GitHub] spark pull request #15618: [SPARK-14914][CORE] Fix Resource not closed after...

2016-10-28 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15618#discussion_r85630990 --- Diff: core/src/test/scala/org/apache/spark/scheduler/TaskResultGetterSuite.scala --- @@ -209,7 +209,8 @@ class TaskResultGetterSuite extends

[GitHub] spark pull request #15618: [SPARK-14914][CORE] Fix Resource not closed after...

2016-10-28 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/15618#discussion_r85436193 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/scheduler/ReceiverTracker.scala --- @@ -194,10 +194,13 @@ class ReceiverTracker(ssc:

[GitHub] spark pull request #15618: [SPARK-14914][CORE] Fix Resource not closed after...

2016-10-28 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/15618#discussion_r85435956 --- Diff: core/src/test/scala/org/apache/spark/scheduler/TaskResultGetterSuite.scala --- @@ -209,7 +209,8 @@ class TaskResultGetterSuite extends

[GitHub] spark pull request #15618: [SPARK-14914][CORE] Fix Resource not closed after...

2016-10-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15618#discussion_r85109184 --- Diff: core/src/main/scala/org/apache/spark/rdd/ReliableCheckpointRDD.scala --- @@ -239,7 +239,14 @@ private[spark] object ReliableCheckpointRDD

[GitHub] spark pull request #15618: [SPARK-14914][CORE] Fix Resource not closed after...

2016-10-26 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15618#discussion_r85107727 --- Diff: core/src/main/scala/org/apache/spark/rdd/ReliableCheckpointRDD.scala --- @@ -239,7 +239,14 @@ private[spark] object ReliableCheckpointRDD extends

[GitHub] spark pull request #15618: [SPARK-14914][CORE] Fix Resource not closed after...

2016-10-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15618#discussion_r85104721 --- Diff: core/src/main/scala/org/apache/spark/rdd/ReliableCheckpointRDD.scala --- @@ -239,7 +239,14 @@ private[spark] object ReliableCheckpointRDD

[GitHub] spark pull request #15618: [SPARK-14914][CORE] Fix Resource not closed after...

2016-10-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15618#discussion_r85104561 --- Diff: core/src/main/scala/org/apache/spark/rdd/ReliableCheckpointRDD.scala --- @@ -239,7 +239,14 @@ private[spark] object ReliableCheckpointRDD

[GitHub] spark pull request #15618: [SPARK-14914][CORE] Fix Resource not closed after...

2016-10-25 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/15618#discussion_r85046075 --- Diff: core/src/main/scala/org/apache/spark/rdd/ReliableCheckpointRDD.scala --- @@ -239,7 +239,14 @@ private[spark] object ReliableCheckpointRDD

[GitHub] spark pull request #15618: [SPARK-14914][CORE] Fix Resource not closed after...

2016-10-25 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/15618#discussion_r85012728 --- Diff: core/src/main/scala/org/apache/spark/rdd/ReliableCheckpointRDD.scala --- @@ -239,7 +239,14 @@ private[spark] object ReliableCheckpointRDD

[GitHub] spark pull request #15618: [SPARK-14914][CORE] Fix Resource not closed after...

2016-10-24 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/15618 [SPARK-14914][CORE] Fix Resource not closed after using, mostly for unit tests ## What changes were proposed in this pull request? Close `FileStreams`, `ZipFiles` etc to release the