[GitHub] spark pull request #15696: [SPARK-18024][SQL] Introduce an internal commit p...

2016-10-31 Thread rxin
Github user rxin closed the pull request at: https://github.com/apache/spark/pull/15696 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] spark pull request #15696: [SPARK-18024][SQL] Introduce an internal commit p...

2016-10-31 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/15696#discussion_r85860719 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/WriteOutput.scala --- @@ -218,22 +210,24 @@ object WriteOutput extends Logging {

[GitHub] spark pull request #15696: [SPARK-18024][SQL] Introduce an internal commit p...

2016-10-31 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/15696#discussion_r85859487 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileCommitProtocol.scala --- @@ -0,0 +1,223 @@ +/* + * Licensed to the Ap

[GitHub] spark pull request #15696: [SPARK-18024][SQL] Introduce an internal commit p...

2016-10-31 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/15696#discussion_r85860514 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileCommitProtocol.scala --- @@ -0,0 +1,223 @@ +/* + * Licensed to the Ap

[GitHub] spark pull request #15696: [SPARK-18024][SQL] Introduce an internal commit p...

2016-10-31 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/15696#discussion_r85859055 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileCommitProtocol.scala --- @@ -0,0 +1,223 @@ +/* + * Licensed to the Ap

[GitHub] spark pull request #15696: [SPARK-18024][SQL] Introduce an internal commit p...

2016-10-31 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/15696#discussion_r85859041 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileCommitProtocol.scala --- @@ -0,0 +1,223 @@ +/* + * Licensed to the Ap

[GitHub] spark pull request #15696: [SPARK-18024][SQL] Introduce an internal commit p...

2016-10-31 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/15696#discussion_r85859292 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileCommitProtocol.scala --- @@ -0,0 +1,223 @@ +/* + * Licensed to the Ap

[GitHub] spark pull request #15696: [SPARK-18024][SQL] Introduce an internal commit p...

2016-10-31 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15696#discussion_r85848357 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/sources/SimpleTextRelation.scala --- @@ -141,15 +139,14 @@ class SimpleTextOutputWriter( } }

[GitHub] spark pull request #15696: [SPARK-18024][SQL] Introduce an internal commit p...

2016-10-31 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15696#discussion_r85848150 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/sources/SimpleTextRelation.scala --- @@ -141,15 +139,14 @@ class SimpleTextOutputWriter( } }

[GitHub] spark pull request #15696: [SPARK-18024][SQL] Introduce an internal commit p...

2016-10-31 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/15696#discussion_r85847969 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/sources/SimpleTextRelation.scala --- @@ -141,15 +139,14 @@ class SimpleTextOutputWriter( }

[GitHub] spark pull request #15696: [SPARK-18024][SQL] Introduce an internal commit p...

2016-10-31 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/15696 [SPARK-18024][SQL] Introduce an internal commit protocol API - WIP ## What changes were proposed in this pull request? This is a work-in-progress pull request to introduce a commit protocol API th